Re: [Mesa-dev] [Mesa-stable] [PATCH] intel/compiler: Account for built-in uniforms in analyze_ubo_ranges

2018-07-25 Thread Dylan Baker
Quoting Jason Ekstrand (2018-07-25 09:38:15) > On Wed, Jul 25, 2018 at 9:30 AM Dylan Baker wrote: > > Quoting Jason Ekstrand (2018-07-24 16:51:26) > > On July 24, 2018 09:05:05 Dylan Baker wrote: > > > > > Quoting Jason Ekstrand (2018-07-23 10:46:31) > > >> The original pass

Re: [Mesa-dev] [Mesa-stable] [PATCH] intel/compiler: Account for built-in uniforms in analyze_ubo_ranges

2018-07-25 Thread Jason Ekstrand
On Wed, Jul 25, 2018 at 9:30 AM Dylan Baker wrote: > Quoting Jason Ekstrand (2018-07-24 16:51:26) > > On July 24, 2018 09:05:05 Dylan Baker wrote: > > > > > Quoting Jason Ekstrand (2018-07-23 10:46:31) > > >> The original pass only looked for load_uniform intrinsics but there > are > > >> a

Re: [Mesa-dev] [Mesa-stable] [PATCH] intel/compiler: Account for built-in uniforms in analyze_ubo_ranges

2018-07-25 Thread Dylan Baker
Quoting Jason Ekstrand (2018-07-24 16:51:26) > On July 24, 2018 09:05:05 Dylan Baker wrote: > > > Quoting Jason Ekstrand (2018-07-23 10:46:31) > >> The original pass only looked for load_uniform intrinsics but there are > >> a number of other places that could end up loading a push constant.

Re: [Mesa-dev] [Mesa-stable] [PATCH] intel/compiler: Account for built-in uniforms in analyze_ubo_ranges

2018-07-24 Thread Jason Ekstrand
On July 24, 2018 09:05:05 Dylan Baker wrote: Quoting Jason Ekstrand (2018-07-23 10:46:31) The original pass only looked for load_uniform intrinsics but there are a number of other places that could end up loading a push constant. One obvious omission was images which always implicitly use a

Re: [Mesa-dev] [Mesa-stable] [PATCH] intel/compiler: Account for built-in uniforms in analyze_ubo_ranges

2018-07-24 Thread Dylan Baker
Quoting Jason Ekstrand (2018-07-23 10:46:31) > The original pass only looked for load_uniform intrinsics but there are > a number of other places that could end up loading a push constant. One > obvious omission was images which always implicitly use a push constant. > Legacy VS clip planes also