Re: [Mesa-dev] [Mesa-stable] [PATCH] nv50/ir: skip optimizing ADD+SHL to SHLADD when src(1) is 0

2017-09-26 Thread Juan A. Suarez Romero
On Tue, 2017-09-26 at 06:45 -0400, Ilia Mirkin wrote: > On Tue, Sep 26, 2017 at 6:30 AM, Samuel Pitoiset > wrote: > > > > > > On 09/26/2017 12:29 PM, Juan A. Suarez Romero wrote: > > > > > > On Mon, 2017-05-01 at 12:11 -0400, Ilia Mirkin wrote: > > > > > > > > On Mon, May 1, 2017 at 12:09 PM,

Re: [Mesa-dev] [Mesa-stable] [PATCH] nv50/ir: skip optimizing ADD+SHL to SHLADD when src(1) is 0

2017-09-26 Thread Ilia Mirkin
On Tue, Sep 26, 2017 at 6:30 AM, Samuel Pitoiset wrote: > > > On 09/26/2017 12:29 PM, Juan A. Suarez Romero wrote: >> >> On Mon, 2017-05-01 at 12:11 -0400, Ilia Mirkin wrote: >>> >>> On Mon, May 1, 2017 at 12:09 PM, Samuel Pitoiset >>> wrote: On 05/01/2017 05:59 PM, Ilia Mirkin wrote: >

Re: [Mesa-dev] [Mesa-stable] [PATCH] nv50/ir: skip optimizing ADD+SHL to SHLADD when src(1) is 0

2017-09-26 Thread Samuel Pitoiset
On 09/26/2017 12:29 PM, Juan A. Suarez Romero wrote: On Mon, 2017-05-01 at 12:11 -0400, Ilia Mirkin wrote: On Mon, May 1, 2017 at 12:09 PM, Samuel Pitoiset wrote: On 05/01/2017 05:59 PM, Ilia Mirkin wrote: I think this is off. It shouldn't matter what the code sequence is, it's all represe

Re: [Mesa-dev] [Mesa-stable] [PATCH] nv50/ir: skip optimizing ADD+SHL to SHLADD when src(1) is 0

2017-09-26 Thread Juan A. Suarez Romero
On Mon, 2017-05-01 at 12:11 -0400, Ilia Mirkin wrote: > On Mon, May 1, 2017 at 12:09 PM, Samuel Pitoiset > wrote: > > On 05/01/2017 05:59 PM, Ilia Mirkin wrote: > > > > > > I think this is off. It shouldn't matter what the code sequence is, > > > it's all representable. You need to teach replaceZ

Re: [Mesa-dev] [Mesa-stable] [PATCH] nv50/ir: skip optimizing ADD+SHL to SHLADD when src(1) is 0

2017-04-29 Thread Karol Herbst
yes. I will follow up with a patch, which will optimize that stuff again 2017-04-29 18:20 GMT+02:00 Samuel Pitoiset : > > > On 04/29/2017 06:14 PM, Emil Velikov wrote: >> >> Hi Samuel, >> >> On 29 April 2017 at 17:01, Samuel Pitoiset >> wrote: >>> >>> Doing '(a << b) + c' when b is 0 is dumb, ADD

Re: [Mesa-dev] [Mesa-stable] [PATCH] nv50/ir: skip optimizing ADD+SHL to SHLADD when src(1) is 0

2017-04-29 Thread Samuel Pitoiset
On 04/29/2017 06:14 PM, Emil Velikov wrote: Hi Samuel, On 29 April 2017 at 17:01, Samuel Pitoiset wrote: Doing '(a << b) + c' when b is 0 is dumb, ADD should be used instead. This fixes a compilation error with Alien Isolation because src(1) is expected to be an immediate value, and the rep

Re: [Mesa-dev] [Mesa-stable] [PATCH] nv50/ir: skip optimizing ADD+SHL to SHLADD when src(1) is 0

2017-04-29 Thread Emil Velikov
Hi Samuel, On 29 April 2017 at 17:01, Samuel Pitoiset wrote: > Doing '(a << b) + c' when b is 0 is dumb, ADD should be used > instead. > > This fixes a compilation error with Alien Isolation because > src(1) is expected to be an immediate value, and the > replaceZero logic will transform 0 to $r6