Re: [Mesa-dev] [Mesa-stable] [PATCH] nvc0: do not clear surfaces bins in the validate function

2016-06-05 Thread Emil Velikov
On 5 June 2016 at 17:56, Samuel Pitoiset wrote: > We should not call nouveau_bufctx_reset() inside a validate function. This seems to contradict the changes introduced in nvc0_compute.c. Worth explaining a bit better the dos and don'ts ? -Emil ___ mesa-

Re: [Mesa-dev] [Mesa-stable] [PATCH] nvc0: do not clear surfaces bins in the validate function

2016-06-05 Thread Emil Velikov
On 5 June 2016 at 22:13, Emil Velikov wrote: > On 5 June 2016 at 17:56, Samuel Pitoiset wrote: >> We should not call nouveau_bufctx_reset() inside a validate function. > This seems to contradict the changes introduced in nvc0_compute.c. > Worth explaining a bit better the dos and don'ts ? > As th

Re: [Mesa-dev] [Mesa-stable] [PATCH] nvc0: do not clear surfaces bins in the validate function

2016-06-05 Thread Ilia Mirkin
On Sun, Jun 5, 2016 at 5:16 PM, Emil Velikov wrote: > On 5 June 2016 at 22:13, Emil Velikov wrote: >> On 5 June 2016 at 17:56, Samuel Pitoiset wrote: >>> We should not call nouveau_bufctx_reset() inside a validate function. >> This seems to contradict the changes introduced in nvc0_compute.c. >>

Re: [Mesa-dev] [Mesa-stable] [PATCH] nvc0: do not clear surfaces bins in the validate function

2016-06-05 Thread Samuel Pitoiset
On 06/05/2016 11:17 PM, Ilia Mirkin wrote: On Sun, Jun 5, 2016 at 5:16 PM, Emil Velikov wrote: On 5 June 2016 at 22:13, Emil Velikov wrote: On 5 June 2016 at 17:56, Samuel Pitoiset wrote: We should not call nouveau_bufctx_reset() inside a validate function. This seems to contradict the c

Re: [Mesa-dev] [Mesa-stable] [PATCH] nvc0: do not clear surfaces bins in the validate function

2016-06-05 Thread Emil Velikov
On 5 June 2016 at 22:17, Ilia Mirkin wrote: > On Sun, Jun 5, 2016 at 5:16 PM, Emil Velikov wrote: >> On 5 June 2016 at 22:13, Emil Velikov wrote: >>> On 5 June 2016 at 17:56, Samuel Pitoiset wrote: We should not call nouveau_bufctx_reset() inside a validate function. >>> This seems to cont

Re: [Mesa-dev] [Mesa-stable] [PATCH] nvc0: do not clear surfaces bins in the validate function

2016-06-05 Thread Ilia Mirkin
On Sun, Jun 5, 2016 at 5:34 PM, Emil Velikov wrote: > On 5 June 2016 at 22:17, Ilia Mirkin wrote: >> On Sun, Jun 5, 2016 at 5:16 PM, Emil Velikov >> wrote: >>> On 5 June 2016 at 22:13, Emil Velikov wrote: On 5 June 2016 at 17:56, Samuel Pitoiset wrote: > We should not call nouveau_bu

Re: [Mesa-dev] [Mesa-stable] [PATCH] nvc0: do not clear surfaces bins in the validate function

2016-06-05 Thread Emil Velikov
On 5 June 2016 at 22:36, Ilia Mirkin wrote: > On Sun, Jun 5, 2016 at 5:34 PM, Emil Velikov wrote: >> On 5 June 2016 at 22:17, Ilia Mirkin wrote: >>> On Sun, Jun 5, 2016 at 5:16 PM, Emil Velikov >>> wrote: On 5 June 2016 at 22:13, Emil Velikov wrote: > On 5 June 2016 at 17:56, Samuel

Re: [Mesa-dev] [Mesa-stable] [PATCH] nvc0: do not clear surfaces bins in the validate function

2016-06-05 Thread Samuel Pitoiset
On 06/05/2016 11:50 PM, Emil Velikov wrote: On 5 June 2016 at 22:36, Ilia Mirkin wrote: On Sun, Jun 5, 2016 at 5:34 PM, Emil Velikov wrote: On 5 June 2016 at 22:17, Ilia Mirkin wrote: On Sun, Jun 5, 2016 at 5:16 PM, Emil Velikov wrote: On 5 June 2016 at 22:13, Emil Velikov wrote: On 5

Re: [Mesa-dev] [Mesa-stable] [PATCH] nvc0: do not clear surfaces bins in the validate function

2016-06-05 Thread Emil Velikov
On 5 June 2016 at 23:00, Samuel Pitoiset wrote: > > > On 06/05/2016 11:50 PM, Emil Velikov wrote: >> >> On 5 June 2016 at 22:36, Ilia Mirkin wrote: >>> >>> On Sun, Jun 5, 2016 at 5:34 PM, Emil Velikov >>> wrote: On 5 June 2016 at 22:17, Ilia Mirkin wrote: > > On Sun, Jun 5, 20

Re: [Mesa-dev] [Mesa-stable] [PATCH] nvc0: do not clear surfaces bins in the validate function

2016-06-05 Thread Samuel Pitoiset
On 06/06/2016 12:08 AM, Emil Velikov wrote: On 5 June 2016 at 23:00, Samuel Pitoiset wrote: On 06/05/2016 11:50 PM, Emil Velikov wrote: On 5 June 2016 at 22:36, Ilia Mirkin wrote: On Sun, Jun 5, 2016 at 5:34 PM, Emil Velikov wrote: On 5 June 2016 at 22:17, Ilia Mirkin wrote: On S

Re: [Mesa-dev] [Mesa-stable] [PATCH] nvc0: do not clear surfaces bins in the validate function

2016-06-05 Thread Ilia Mirkin
On Sun, Jun 5, 2016 at 6:08 PM, Emil Velikov wrote: > On 5 June 2016 at 23:00, Samuel Pitoiset wrote: >> >> >> On 06/05/2016 11:50 PM, Emil Velikov wrote: >>> >>> On 5 June 2016 at 22:36, Ilia Mirkin wrote: On Sun, Jun 5, 2016 at 5:34 PM, Emil Velikov wrote: > > On 5 June

Re: [Mesa-dev] [Mesa-stable] [PATCH] nvc0: do not clear surfaces bins in the validate function

2016-06-05 Thread Emil Velikov
On 5 June 2016 at 23:22, Ilia Mirkin wrote: > On Sun, Jun 5, 2016 at 6:08 PM, Emil Velikov wrote: >> On 5 June 2016 at 23:00, Samuel Pitoiset wrote: >>> >>> >>> On 06/05/2016 11:50 PM, Emil Velikov wrote: On 5 June 2016 at 22:36, Ilia Mirkin wrote: > > On Sun, Jun 5, 2016 at 5

Re: [Mesa-dev] [Mesa-stable] [PATCH] nvc0: do not clear surfaces bins in the validate function

2016-06-05 Thread Samuel Pitoiset
On 06/06/2016 12:30 AM, Emil Velikov wrote: On 5 June 2016 at 23:22, Ilia Mirkin wrote: On Sun, Jun 5, 2016 at 6:08 PM, Emil Velikov wrote: On 5 June 2016 at 23:00, Samuel Pitoiset wrote: On 06/05/2016 11:50 PM, Emil Velikov wrote: On 5 June 2016 at 22:36, Ilia Mirkin wrote: On Sun

Re: [Mesa-dev] [Mesa-stable] [PATCH] nvc0: do not clear surfaces bins in the validate function

2016-06-05 Thread Ilia Mirkin
On Sun, Jun 5, 2016 at 6:30 PM, Emil Velikov wrote: > On 5 June 2016 at 23:22, Ilia Mirkin wrote: >> You're arguing about clarity with the ~2 active developers/reviewers >> who understand the code. > What I'm saying is that with contradicting commit messages like this > one there'll be little oth