Re: [Mesa-dev] [Mesa-stable] [PATCH] radeon/vce: move feedback command inside of destroy function

2018-04-08 Thread Juan A. Suarez Romero
On Fri, 2018-04-06 at 11:20 -0700, Mark Janes wrote: > Emil Velikov writes: > > > On 5 April 2018 at 20:33, Mark Janes > > wrote: > > > Emil Velikov writes: > > > > > > > On 4 April 2018 at 22:50, Mark Janes

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeon/vce: move feedback command inside of destroy function

2018-04-06 Thread Ian Romanick
On 04/04/2018 11:30 AM, Mark Janes wrote: > Emil Velikov writes: > >> On 4 April 2018 at 17:40, Mark Janes wrote: >>> Leo Liu writes: >>> On the CI family, firmware requires the destory command have to be the last

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeon/vce: move feedback command inside of destroy function

2018-04-06 Thread Mark Janes
Emil Velikov writes: > (Dropping Leo, since it doesn't affect him. He's already subscribed to > the list.) > > On 6 April 2018 at 19:20, Mark Janes wrote: > >> I agree with you, however our release process still has a gap. We >> (Intel) test

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeon/vce: move feedback command inside of destroy function

2018-04-06 Thread Emil Velikov
(Dropping Leo, since it doesn't affect him. He's already subscribed to the list.) On 6 April 2018 at 19:20, Mark Janes wrote: > I agree with you, however our release process still has a gap. We > (Intel) test commits on master, and file bugs when we find them in i965 >

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeon/vce: move feedback command inside of destroy function

2018-04-06 Thread Mark Janes
Emil Velikov writes: > On 5 April 2018 at 20:33, Mark Janes wrote: >> Emil Velikov writes: >> >>> On 4 April 2018 at 22:50, Mark Janes wrote: Leo Liu writes: >

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeon/vce: move feedback command inside of destroy function

2018-04-06 Thread Emil Velikov
On 5 April 2018 at 20:33, Mark Janes wrote: > Emil Velikov writes: > >> On 4 April 2018 at 22:50, Mark Janes wrote: >>> Leo Liu writes: >>> On 04/04/2018 12:40 PM, Mark Janes wrote: > Leo Liu

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeon/vce: move feedback command inside of destroy function

2018-04-05 Thread Mark Janes
Emil Velikov writes: > On 4 April 2018 at 22:50, Mark Janes wrote: >> Leo Liu writes: >> >>> On 04/04/2018 12:40 PM, Mark Janes wrote: Leo Liu writes: > On the CI family, firmware requires the

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeon/vce: move feedback command inside of destroy function

2018-04-05 Thread Emil Velikov
On 4 April 2018 at 22:50, Mark Janes wrote: > Leo Liu writes: > >> On 04/04/2018 12:40 PM, Mark Janes wrote: >>> Leo Liu writes: >>> On the CI family, firmware requires the destory command have to be the last command in the IB,

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeon/vce: move feedback command inside of destroy function

2018-04-04 Thread Mark Janes
Leo Liu writes: > On 04/04/2018 12:40 PM, Mark Janes wrote: >> Leo Liu writes: >> >>> On the CI family, firmware requires the destory command have to be the >>> last command in the IB, moving feedback command after destroy is causing >>> issues on CI cards, so

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeon/vce: move feedback command inside of destroy function

2018-04-04 Thread Leo Liu
On 04/04/2018 12:40 PM, Mark Janes wrote: Leo Liu writes: On the CI family, firmware requires the destory command have to be the last command in the IB, moving feedback command after destroy is causing issues on CI cards, so we have to keep the previous logic that moves

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeon/vce: move feedback command inside of destroy function

2018-04-04 Thread Mark Janes
Emil Velikov writes: > On 4 April 2018 at 17:40, Mark Janes wrote: >> Leo Liu writes: >> >>> On the CI family, firmware requires the destory command have to be the >>> last command in the IB, moving feedback command after

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeon/vce: move feedback command inside of destroy function

2018-04-04 Thread Emil Velikov
On 4 April 2018 at 17:40, Mark Janes wrote: > Leo Liu writes: > >> On the CI family, firmware requires the destory command have to be the >> last command in the IB, moving feedback command after destroy is causing >> issues on CI cards, so we have to keep

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeon/vce: move feedback command inside of destroy function

2018-04-04 Thread Juan A. Suarez Romero
On Wed, 2018-04-04 at 09:40 -0700, Mark Janes wrote: > Leo Liu writes: > > > On the CI family, firmware requires the destory command have to be the > > last command in the IB, moving feedback command after destroy is causing > > issues on CI cards, so we have to keep the

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeon/vce: move feedback command inside of destroy function

2018-04-04 Thread Mark Janes
Leo Liu writes: > On the CI family, firmware requires the destory command have to be the > last command in the IB, moving feedback command after destroy is causing > issues on CI cards, so we have to keep the previous logic that moves > destroy back to the last command. > > But