[Mesa-dev] [PATCH] Allow setting GL_TEXTURE_COMPARE_MODE on a sampler object without ARB_shadow support.

2015-03-23 Thread Stefan Dösinger
This fixes a GL error warning on r200 in Wine. The GL_ARB_sampler_objects extension does not specify a dependency on GL_ARB_shadow or GL_ARB_depth_texture for this value. Just set the value and don't do anything else. It won't matter without a depth texture being assigned anyway. --- src/mesa/mai

Re: [Mesa-dev] [PATCH] Allow setting GL_TEXTURE_COMPARE_MODE on a sampler object without ARB_shadow support.

2015-06-26 Thread Brian Paul
On 06/25/2015 05:11 PM, Matt Turner wrote: On Mon, Mar 23, 2015 at 12:25 PM, Stefan Dösinger wrote: This fixes a GL error warning on r200 in Wine. The GL_ARB_sampler_objects extension does not specify a dependency on GL_ARB_shadow or GL_ARB_depth_texture for this value. Just set the value and

Re: [Mesa-dev] [PATCH] Allow setting GL_TEXTURE_COMPARE_MODE on a sampler object without ARB_shadow support.

2015-06-27 Thread Henri Verbeet
On 26 June 2015 at 17:38, Brian Paul wrote: > Digging up the patch from March for reference: > >> This fixes a GL error warning on r200 in Wine. >> >> The GL_ARB_sampler_objects extension does not specify a dependency on >> GL_ARB_shadow or GL_ARB_depth_texture for this value. Just set the value >

[Mesa-dev] [PATCH] Allow setting GL_TEXTURE_COMPARE_MODE on a sampler object without ARB_shadow support (v2).

2015-07-30 Thread Stefan Dösinger
Version 2: Return GL_FALSE if ARB_shadow is unsupported instead of pretending to store the value as suggested by Brian Paul. This fixes a GL error warning on r200 in Wine. The GL_ARB_sampler_objects extension does not specify a dependency on GL_ARB_shadow or GL_ARB_depth_texture for this value.

Re: [Mesa-dev] [PATCH] Allow setting GL_TEXTURE_COMPARE_MODE on a sampler object without ARB_shadow support.

2015-06-25 Thread Matt Turner
On Mon, Mar 23, 2015 at 12:25 PM, Stefan Dösinger wrote: > This fixes a GL error warning on r200 in Wine. > > The GL_ARB_sampler_objects extension does not specify a dependency on > GL_ARB_shadow or GL_ARB_depth_texture for this value. Just set the value > and don't do anything else. It won't matt

Re: [Mesa-dev] [PATCH] Allow setting GL_TEXTURE_COMPARE_MODE on a sampler object without ARB_shadow support (v2).

2015-07-30 Thread Brian Paul
Can you try to shorten the subject line to 75 chars or less? It should also start with "mesa:". Perhaps: "mesa: disable texture compare mode error checking for Wine" On 07/30/2015 07:04 AM, Stefan Dösinger wrote: Version 2: Return GL_FALSE if ARB_shadow is unsupported instead of pretending

Re: [Mesa-dev] [PATCH] Allow setting GL_TEXTURE_COMPARE_MODE on a sampler object without ARB_shadow support (v2).

2015-07-30 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, Thanks for the quick feedback! I'll resend the patch with the requested fixes shortly. Stefan Am 2015-07-30 um 15:30 schrieb Brian Paul: > Can you try to shorten the subject line to 75 chars or less? It > should also start with "mesa:". Perhap