[Mesa-dev] [PATCH] Bad free in _mesa_delete_buffer_object

2014-01-31 Thread Colin Harrison
Hi, I can get a crash without this change (now _mesa_align_malloc is being used for buffer object data) --- ./src/mesa/main/save_bufferobj.c2014-01-29 17:23:22.387706584 + +++ ./src/mesa/main/bufferobj.c 2014-01-31 11:01:26.164078585 + @@ -407,7 +407,7 @@ _mesa_delete_buffer_object(st

Re: [Mesa-dev] [PATCH] Bad free in _mesa_delete_buffer_object

2014-01-31 Thread Siavash Eliasi
Hello, I'm responsible for the caused inconvenience. I forgot to use _mesa_align_free to clean up the allocated memory blocked using _mesa_align_malloc. Good catch and thanks for the patch! :) On POSIX aligned allocated memory (using posix_memalign) should be freed using ordinary free() and I

Re: [Mesa-dev] [PATCH] Bad free in _mesa_delete_buffer_object

2014-01-31 Thread Siavash Eliasi
Hello, on which OS is this happening? On 01/31/2014 02:38 PM, Colin Harrison wrote: Hi, I can get a crash without this change (now _mesa_align_malloc is being used for buffer object data) --- ./src/mesa/main/save_bufferobj.c2014-01-29 17:23:22.387706584 + +++ ./src/mesa/main/bufferobj.

Re: [Mesa-dev] [PATCH] Bad free in _mesa_delete_buffer_object

2014-01-31 Thread Brian Paul
On 01/31/2014 04:08 AM, Colin Harrison wrote: Hi, I can get a crash without this change (now _mesa_align_malloc is being used for buffer object data) --- ./src/mesa/main/save_bufferobj.c2014-01-29 17:23:22.387706584 + +++ ./src/mesa/main/bufferobj.c 2014-01-31 11:01:26.164078585 + @