[Mesa-dev] [PATCH] Delete duplicate function is_power_of_two() and use _mesa_is_pow_two()

2015-07-28 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- src/mesa/drivers/common/meta_blit.c | 6 +++--- src/mesa/drivers/dri/i915/i915_texstate.c | 2 +- src/mesa/drivers/dri/i965/brw_fs_vector_splitting.cpp | 2 +- src/mesa/drivers/dri/i965/brw_reg.h | 2 +- src/mesa/d

Re: [Mesa-dev] [PATCH] Delete duplicate function is_power_of_two() and use _mesa_is_pow_two()

2015-07-28 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 07/29/2015 02:48 AM, Anuj Phogat wrote: Signed-off-by: Anuj Phogat --- src/mesa/drivers/common/meta_blit.c | 6 +++--- src/mesa/drivers/dri/i915/i915_texstate.c | 2 +- src/mesa/drivers/dri/i965/brw_fs_vector_splitting.cpp | 2 +

Re: [Mesa-dev] [PATCH] Delete duplicate function is_power_of_two() and use _mesa_is_pow_two()

2015-07-29 Thread Iago Toral
Funny, we had 3 instances of the same function with the same implementation :), there is still util_is_power_of_two in Gallium btw. Reviewed-by: Iago Toral Quiroga On Tue, 2015-07-28 at 16:48 -0700, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/common/meta_blit.c

Re: [Mesa-dev] [PATCH] Delete duplicate function is_power_of_two() and use _mesa_is_pow_two()

2015-07-29 Thread Neil Roberts
It seems a bit weird to modify the the is_power_of_two functions in format_parser.py, was that intentional? It doesn't look like those functions are actually used anywhere so maybe we could just remove them, although it would probably make sense to do that in a separate patch. Regards, - Neil Anu

Re: [Mesa-dev] [PATCH] Delete duplicate function is_power_of_two() and use _mesa_is_pow_two()

2015-07-29 Thread Anuj Phogat
On Wed, Jul 29, 2015 at 12:20 AM, Iago Toral wrote: > Funny, we had 3 instances of the same function with the same > implementation :), there is still util_is_power_of_two in Gallium btw. > Yes. I wasn't sure if we can use main/imports.h in gallium. So, I didn't touch it. > Reviewed-by: Iago Tor

Re: [Mesa-dev] [PATCH] Delete duplicate function is_power_of_two() and use _mesa_is_pow_two()

2015-07-29 Thread Anuj Phogat
On Wed, Jul 29, 2015 at 8:16 AM, Neil Roberts wrote: > It seems a bit weird to modify the the is_power_of_two functions in > format_parser.py, was that intentional? It doesn't look like those > functions are actually used anywhere so maybe we could just remove them, > although it would probably ma

Re: [Mesa-dev] [PATCH] Delete duplicate function is_power_of_two() and use _mesa_is_pow_two()

2015-07-30 Thread Michel Dänzer
On 30.07.2015 01:27, Anuj Phogat wrote: > On Wed, Jul 29, 2015 at 12:20 AM, Iago Toral wrote: >> Funny, we had 3 instances of the same function with the same >> implementation :), there is still util_is_power_of_two in Gallium btw. >> > Yes. I wasn't sure if we can use main/imports.h in gallium.