On Wed, Jul 17, 2013 at 09:46:43AM -0500, Aaron Watry wrote:
Hi Tom,
I have verified that these patches, along with the previous one fix
the errors that I was getting for SI. The test case from that FD.o
bug still fails, but that's due to attempting to sign extend the
v2i1/v4i1 result to
Hi Tom,
I have verified that these patches, along with the previous one fix
the errors that I was getting for SI. The test case from that FD.o
bug still fails, but that's due to attempting to sign extend the
v2i1/v4i1 result to v2i32/v4i32, which isn't necessary when doing
vselect properly.
From: Tom Stellard thomas.stell...@amd.com
---
lib/Target/R600/AMDGPUISelLowering.cpp | 3 +++
lib/Target/R600/R600ISelLowering.cpp | 3 ---
test/CodeGen/R600/vselect.ll | 30 ++
3 files changed, 33 insertions(+), 3 deletions(-)
diff --git
Looks good to me.
I've tested on Cedar (HD5400) with no OpenCL regressions, but cannot
test on SI because SETCC still causes issues (see
https://bugs.freedesktop.org/show_bug.cgi?id=66175). Once SETCC is
fixed for SI, we should probably add SI-CHECK lines to vselect.ll
--Aaron
On Tue, Jul 16,
Hi,
The attached three patches along with this one should fix VSELECT on SI
as well.
-Tom
On Tue, Jul 16, 2013 at 05:12:40PM -0500, Aaron Watry wrote:
Looks good to me.
I've tested on Cedar (HD5400) with no OpenCL regressions, but cannot
test on SI because SETCC still causes issues (see