Re: [Mesa-dev] [PATCH] Revert "intel/nir: Call nir_lower_io_to_scalar_early"

2018-08-15 Thread Jason Ekstrand
On Wed, Aug 15, 2018 at 5:36 PM Timothy Arceri wrote: > On 16/08/18 02:10, Jason Ekstrand wrote: > > On Tue, Aug 14, 2018 at 7:25 PM Timothy Arceri > > wrote: > > > > On 09/08/18 05:05, Jason Ekstrand wrote: > > > Commit 4434591bf56a6b0 caused

Re: [Mesa-dev] [PATCH] Revert "intel/nir: Call nir_lower_io_to_scalar_early"

2018-08-15 Thread Mark Janes
This corrects all of the performance regressions that I can see on our perf CI. Please make sure to add the fixes tag before pushing. Tested-by: Mark Janes Jason Ekstrand writes: > Commit 4434591bf56a6b0 caused substantially more URB messages in > geometry and tessellation shaders. Before

Re: [Mesa-dev] [PATCH] Revert "intel/nir: Call nir_lower_io_to_scalar_early"

2018-08-15 Thread Timothy Arceri
On 16/08/18 02:10, Jason Ekstrand wrote: On Tue, Aug 14, 2018 at 7:25 PM Timothy Arceri > wrote: On 09/08/18 05:05, Jason Ekstrand wrote: > Commit 4434591bf56a6b0 caused substantially more URB messages in > geometry and tessellation shaders.  Before

Re: [Mesa-dev] [PATCH] Revert "intel/nir: Call nir_lower_io_to_scalar_early"

2018-08-15 Thread Jason Ekstrand
On Tue, Aug 14, 2018 at 7:25 PM Timothy Arceri wrote: > On 09/08/18 05:05, Jason Ekstrand wrote: > > Commit 4434591bf56a6b0 caused substantially more URB messages in > > geometry and tessellation shaders. Before we can really enable this > > sort of optimization, We either need some way of

Re: [Mesa-dev] [PATCH] Revert "intel/nir: Call nir_lower_io_to_scalar_early"

2018-08-14 Thread Timothy Arceri
On 09/08/18 05:05, Jason Ekstrand wrote: Commit 4434591bf56a6b0 caused substantially more URB messages in geometry and tessellation shaders. Before we can really enable this sort of optimization, We either need some way of combining them back together into vectors or we need to do cross-stage

Re: [Mesa-dev] [PATCH] Revert "intel/nir: Call nir_lower_io_to_scalar_early"

2018-08-14 Thread Dylan Baker
I don't think this will be picked up by the stable spotting scripts, does it need a Fixes: tag? Dylan Quoting Jason Ekstrand (2018-08-08 12:05:00) > Commit 4434591bf56a6b0 caused substantially more URB messages in > geometry and tessellation shaders. Before we can really enable this > sort of

Re: [Mesa-dev] [PATCH] Revert "intel/nir: Call nir_lower_io_to_scalar_early"

2018-08-14 Thread Kenneth Graunke
On Wednesday, August 8, 2018 12:05:00 PM PDT Jason Ekstrand wrote: > Commit 4434591bf56a6b0 caused substantially more URB messages in > geometry and tessellation shaders. Before we can really enable this > sort of optimization, We either need some way of combining them back > together into

[Mesa-dev] [PATCH] Revert "intel/nir: Call nir_lower_io_to_scalar_early"

2018-08-08 Thread Jason Ekstrand
Commit 4434591bf56a6b0 caused substantially more URB messages in geometry and tessellation shaders. Before we can really enable this sort of optimization, We either need some way of combining them back together into vectors or we need to do cross-stage vector element elimination without