Re: [Mesa-dev] [PATCH] ac: fix get_image_coords() for radeonsi

2018-07-31 Thread Timothy Arceri
On 31/07/18 16:52, Bas Nieuwenhuizen wrote: On Fri, Jul 27, 2018 at 11:40 AM, Timothy Arceri wrote: On 27/07/18 19:10, Bas Nieuwenhuizen wrote: On Fri, Jul 27, 2018 at 7:32 AM, Timothy Arceri wrote: Because this was setting image to true we would end up calling si_load_image_desc() whe

Re: [Mesa-dev] [PATCH] ac: fix get_image_coords() for radeonsi

2018-07-30 Thread Bas Nieuwenhuizen
On Fri, Jul 27, 2018 at 11:40 AM, Timothy Arceri wrote: > > > On 27/07/18 19:10, Bas Nieuwenhuizen wrote: >> >> On Fri, Jul 27, 2018 at 7:32 AM, Timothy Arceri >> wrote: >>> >>> Because this was setting image to true we would end up calling >>> si_load_image_desc() when we sould be calling >>> si

Re: [Mesa-dev] [PATCH] ac: fix get_image_coords() for radeonsi

2018-07-30 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Jul 27, 2018 at 1:32 AM, Timothy Arceri wrote: > Because this was setting image to true we would end up calling > si_load_image_desc() when we sould be calling > si_load_sampler_desc(). > > This fixes an assert() in Deus Ex: MD > --- > src/amd/common/ac_n

Re: [Mesa-dev] [PATCH] ac: fix get_image_coords() for radeonsi

2018-07-27 Thread Timothy Arceri
On 27/07/18 19:10, Bas Nieuwenhuizen wrote: On Fri, Jul 27, 2018 at 7:32 AM, Timothy Arceri wrote: Because this was setting image to true we would end up calling si_load_image_desc() when we sould be calling si_load_sampler_desc(). Since the descriptor is part of an image, not a sampler, ge

Re: [Mesa-dev] [PATCH] ac: fix get_image_coords() for radeonsi

2018-07-27 Thread Bas Nieuwenhuizen
On Fri, Jul 27, 2018 at 7:32 AM, Timothy Arceri wrote: > Because this was setting image to true we would end up calling > si_load_image_desc() when we sould be calling > si_load_sampler_desc(). Since the descriptor is part of an image, not a sampler, get_image_descriptor looks like the right thin

[Mesa-dev] [PATCH] ac: fix get_image_coords() for radeonsi

2018-07-26 Thread Timothy Arceri
Because this was setting image to true we would end up calling si_load_image_desc() when we sould be calling si_load_sampler_desc(). This fixes an assert() in Deus Ex: MD --- src/amd/common/ac_nir_to_llvm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_ni