Re: [Mesa-dev] [PATCH] amd: remove support for LLVM 3.9

2018-02-02 Thread Dylan Baker
I went ahead and pushed my patch, the only things you should need to do for the meson side now is move with_gallium_radeonsi, and remove the stray `s` in the error message. Dylan Quoting Bas Nieuwenhuizen (2018-02-02 11:56:26) > I'd prefer if Dylan's patch goes first, as we are bumping swr too

Re: [Mesa-dev] [PATCH] amd: remove support for LLVM 3.9

2018-02-02 Thread Bas Nieuwenhuizen
I'd prefer if Dylan's patch goes first, as we are bumping swr too otherwise. Though either way: Reviewed-by: Bas Nieuwenhuizen On Fri, Feb 2, 2018 at 8:15 PM, Dylan Baker wrote: > FYI: I sent out a patch a few minutes ago to set the minimum

Re: [Mesa-dev] [PATCH] amd: remove support for LLVM 3.9

2018-02-02 Thread Dylan Baker
FYI: I sent out a patch a few minutes ago to set the minimum version more like autotools does, but I'm fine with this landing first. Reviewed-by: Dylan Baker Quoting Marek Olšák (2018-02-02 11:07:57) > Adding this: > > diff --git a/meson.build b/meson.build > index

Re: [Mesa-dev] [PATCH] amd: remove support for LLVM 3.9

2018-02-02 Thread Marek Olšák
Adding this: diff --git a/meson.build b/meson.build index 80ea60f..22eb702 100644 --- a/meson.build +++ b/meson.build @@ -991,12 +991,12 @@ endif _llvm = get_option('llvm') if _llvm == 'auto' dep_llvm = dependency( -'llvm', version : '>= 3.9.0', modules : llvm_modules, +'llvm',

Re: [Mesa-dev] [PATCH] amd: remove support for LLVM 3.9

2018-02-02 Thread Bas Nieuwenhuizen
Also change meson.build? On Fri, Feb 2, 2018 at 7:34 PM, Marek Olšák wrote: > From: Marek Olšák > > Only these are supported: > - LLVM 4.0 > - LLVM 5.0 > - LLVM 6.0 > - master (7.0) > --- > configure.ac | 4 +- >

[Mesa-dev] [PATCH] amd: remove support for LLVM 3.9

2018-02-02 Thread Marek Olšák
From: Marek Olšák Only these are supported: - LLVM 4.0 - LLVM 5.0 - LLVM 6.0 - master (7.0) --- configure.ac | 4 +- src/amd/common/ac_llvm_build.c | 187 ++--- src/amd/common/ac_llvm_helper.cpp