Re: [Mesa-dev] [PATCH] android: radv: add libmesa_git_sha1 static dependency

2018-11-03 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Fri, Nov 2, 2018 at 3:54 PM Eric Engestrom wrote: > > On Friday, 2018-11-02 13:38:53 +0100, Mauro Rossi wrote: > > Hi all, > > could somebody provide Reviewed-by in order to apply in mesa-dev and > > avoid trivial building error? > > Not an expert on Android.mk,

Re: [Mesa-dev] [PATCH] android: radv: add libmesa_git_sha1 static dependency

2018-11-02 Thread Eric Engestrom
On Friday, 2018-11-02 13:38:53 +0100, Mauro Rossi wrote: > Hi all, > could somebody provide Reviewed-by in order to apply in mesa-dev and > avoid trivial building error? Not an expert on Android.mk, but this looks reasonable, and adding that dep is definitely right, so: Reviewed-by: Eric Engestrom

Re: [Mesa-dev] [PATCH] android: radv: add libmesa_git_sha1 static dependency

2018-11-02 Thread Mauro Rossi
Hi all, could somebody provide Reviewed-by in order to apply in mesa-dev and avoid trivial building error? Thanks Mauro On Tue, Oct 30, 2018 at 10:42 PM Mauro Rossi wrote: > > libmesa_git_sha1 whole static dependency is added to get git_sha1.h header > and avoid following building error: > > exte

Re: [Mesa-dev] [PATCH] android: radv: add libmesa_git_sha1 static dependency

2018-10-31 Thread Samuel Pitoiset
Acked-by: Samuel Pitoiset On 10/30/18 10:41 PM, Mauro Rossi wrote: libmesa_git_sha1 whole static dependency is added to get git_sha1.h header and avoid following building error: external/mesa/src/amd/vulkan/radv_device.c:46:10: fatal error: 'git_sha1.h' file not found ^ 1 error gener

[Mesa-dev] [PATCH] android: radv: add libmesa_git_sha1 static dependency

2018-10-30 Thread Mauro Rossi
libmesa_git_sha1 whole static dependency is added to get git_sha1.h header and avoid following building error: external/mesa/src/amd/vulkan/radv_device.c:46:10: fatal error: 'git_sha1.h' file not found ^ 1 error generated. Fixes: 9d40ec2cf6 ("radv: Add support for VK_KHR_driver_propertie