Re: [Mesa-dev] [PATCH] anv/cmd_buffer: check for NULL framebuffer

2019-02-12 Thread Juan A. Suarez Romero
On Tue, 2019-02-12 at 11:31 -0600, Jason Ekstrand wrote: > On Tue, Feb 12, 2019 at 10:48 AM Juan A. Suarez Romero > wrote: > > This can happen when we record a VkCmdDraw in a secondary buffer that > > > > was created inheriting from the primary buffer, but with the framebuffer > > > > set to

[Mesa-dev] [PATCH] anv/cmd_buffer: check for NULL framebuffer

2019-02-12 Thread Juan A. Suarez Romero
This can happen when we record a VkCmdDraw in a secondary buffer that was created inheriting from the primary buffer, but with the framebuffer set to NULL in the VkCommandBufferInheritanceInfo. Vulkan 1.1.81 spec says that "the application must ensure (using scissor if neccesary) that all

Re: [Mesa-dev] [PATCH] anv/cmd_buffer: check for NULL framebuffer

2019-02-12 Thread Jason Ekstrand
On Tue, Feb 12, 2019 at 10:48 AM Juan A. Suarez Romero wrote: > This can happen when we record a VkCmdDraw in a secondary buffer that > was created inheriting from the primary buffer, but with the framebuffer > set to NULL in the VkCommandBufferInheritanceInfo. > > Vulkan 1.1.81 spec says that

Re: [Mesa-dev] [PATCH] anv/cmd_buffer: check for NULL framebuffer

2019-02-08 Thread Juan A. Suarez Romero
On Mon, 2019-02-04 at 10:01 -0600, Jason Ekstrand wrote: > On Mon, Feb 4, 2019 at 3:02 AM Juan A. Suarez Romero > wrote: > > On Fri, 2019-02-01 at 15:33 -0600, Jason Ekstrand wrote: > > > > > On Fri, Feb 1, 2019 at 10:14 AM Juan A. Suarez Romero > > > wrote: > > > > > > This can happen when

Re: [Mesa-dev] [PATCH] anv/cmd_buffer: check for NULL framebuffer

2019-02-04 Thread Jason Ekstrand
On Mon, Feb 4, 2019 at 3:02 AM Juan A. Suarez Romero wrote: > On Fri, 2019-02-01 at 15:33 -0600, Jason Ekstrand wrote: > > On Fri, Feb 1, 2019 at 10:14 AM Juan A. Suarez Romero < > jasua...@igalia.com> wrote: > > > This can happen when we record a VkCmdDraw in a secondary buffer that > > > was

Re: [Mesa-dev] [PATCH] anv/cmd_buffer: check for NULL framebuffer

2019-02-04 Thread Juan A. Suarez Romero
On Fri, 2019-02-01 at 15:33 -0600, Jason Ekstrand wrote: > On Fri, Feb 1, 2019 at 10:14 AM Juan A. Suarez Romero > wrote: > > This can happen when we record a VkCmdDraw in a secondary buffer that > > was created inheriting from the primary buffer, but with the framebuffer > > set to NULL in the

Re: [Mesa-dev] [PATCH] anv/cmd_buffer: check for NULL framebuffer

2019-02-01 Thread Jason Ekstrand
On Fri, Feb 1, 2019 at 10:14 AM Juan A. Suarez Romero wrote: > This can happen when we record a VkCmdDraw in a secondary buffer that > was created inheriting from the primary buffer, but with the framebuffer > set to NULL in the VkCommandBufferInheritanceInfo. > > CC: Jason Ekstrand > --- >

[Mesa-dev] [PATCH] anv/cmd_buffer: check for NULL framebuffer

2019-02-01 Thread Juan A. Suarez Romero
This can happen when we record a VkCmdDraw in a secondary buffer that was created inheriting from the primary buffer, but with the framebuffer set to NULL in the VkCommandBufferInheritanceInfo. CC: Jason Ekstrand --- src/intel/vulkan/gen7_cmd_buffer.c | 13 +++-- 1 file changed, 11