[Mesa-dev] [PATCH] anv/state: if enabled, use anisotropic filtering also with VK_FILTER_NEAREST

2016-11-24 Thread Iago Toral Quiroga
Fixes multiple Vulkan CTS tests that combine anisotropy and VK_FILTER_NEAREST in dEQP-VK.texture.filtering_anisotropy.* --- src/intel/vulkan/genX_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/genX_state.c b/src/intel/vulkan/genX_state.c index 4122395.

Re: [Mesa-dev] [PATCH] anv/state: if enabled, use anisotropic filtering also with VK_FILTER_NEAREST

2016-11-24 Thread Lionel Landwerlin
Hi Iago, Looking at the history, before ed4fe3e9ba9018e68afe6fdd4f267218a537fdaa we seem to set min/mag filter to MAPFILTER_ANISOTROPIC if maxAnisotropy > 1. It seems your patch makes sense in using MAPFILTER_ANISOTROPIC in the NEAREST case, but I wonder whether we should also check for maxAn

Re: [Mesa-dev] [PATCH] anv/state: if enabled, use anisotropic filtering also with VK_FILTER_NEAREST

2016-11-24 Thread Iago Toral
Hi Lionel, On Thu, 2016-11-24 at 13:08 +, Lionel Landwerlin wrote: > Hi Iago, > > Looking at the history, before > ed4fe3e9ba9018e68afe6fdd4f267218a537fdaa  > we seem to set min/mag filter to MAPFILTER_ANISOTROPIC if > maxAnisotropy  >  > 1. It seems your patch makes sense in using MAPFILTER_

Re: [Mesa-dev] [PATCH] anv/state: if enabled, use anisotropic filtering also with VK_FILTER_NEAREST

2016-11-24 Thread Iago Toral
On Thu, 2016-11-24 at 14:33 +0100, Iago Toral wrote: > Hi Lionel, > > On Thu, 2016-11-24 at 13:08 +, Lionel Landwerlin wrote: > > > > Hi Iago, > > > > Looking at the history, before > > ed4fe3e9ba9018e68afe6fdd4f267218a537fdaa  > > we seem to set min/mag filter to MAPFILTER_ANISOTROPIC if >

Re: [Mesa-dev] [PATCH] anv/state: if enabled, use anisotropic filtering also with VK_FILTER_NEAREST

2016-11-24 Thread Lionel Landwerlin
Thanks for the explanation, feel free to wait for Jason's rb otherwise : Reviewed-by: Lionel Landwerlin ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] anv/state: if enabled, use anisotropic filtering also with VK_FILTER_NEAREST

2016-11-24 Thread Jason Ekstrand
On Nov 24, 2016 7:12 AM, "Iago Toral" wrote: > > On Thu, 2016-11-24 at 14:33 +0100, Iago Toral wrote: > > Hi Lionel, > > > > On Thu, 2016-11-24 at 13:08 +, Lionel Landwerlin wrote: > > > > > > Hi Iago, > > > > > > Looking at the history, before > > > ed4fe3e9ba9018e68afe6fdd4f267218a537fdaa >

Re: [Mesa-dev] [PATCH] anv/state: if enabled, use anisotropic filtering also with VK_FILTER_NEAREST

2016-11-24 Thread Iago Toral
On Thu, 2016-11-24 at 16:28 -0800, Jason Ekstrand wrote: > > On Nov 24, 2016 7:12 AM, "Iago Toral" wrote: > > > > On Thu, 2016-11-24 at 14:33 +0100, Iago Toral wrote: > > > Hi Lionel, > > > > > > On Thu, 2016-11-24 at 13:08 +, Lionel Landwerlin wrote: > > > > > > > > Hi Iago, > > > > > > > >

Re: [Mesa-dev] [PATCH] anv/state: if enabled, use anisotropic filtering also with VK_FILTER_NEAREST

2016-11-25 Thread Jason Ekstrand
On Nov 24, 2016 11:19 PM, "Iago Toral" wrote: > > On Thu, 2016-11-24 at 16:28 -0800, Jason Ekstrand wrote: > > > > On Nov 24, 2016 7:12 AM, "Iago Toral" wrote: > > > > > > On Thu, 2016-11-24 at 14:33 +0100, Iago Toral wrote: > > > > Hi Lionel, > > > > > > > > On Thu, 2016-11-24 at 13:08 +, Li