Re: [Mesa-dev] [PATCH] automake: include the git sha in the opengl version string for oot builds

2014-01-13 Thread Chad Versace
On Mon, Jan 13, 2014 at 02:02:12AM +, Emil Velikov wrote: Because it's a great feature and we should not penalise people for doing out-of-tree builds. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/mesa/Makefile.am | 12 ++-- 1 file changed, 6 insertions(+), 6

[Mesa-dev] [PATCH] automake: include the git sha in the opengl version string for oot builds

2014-01-12 Thread Emil Velikov
Because it's a great feature and we should not penalise people for doing out-of-tree builds. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/mesa/Makefile.am | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mesa/Makefile.am b/src/mesa/Makefile.am

Re: [Mesa-dev] [PATCH] automake: include the git sha in the opengl version string for oot builds

2014-01-12 Thread Matt Turner
On Sun, Jan 12, 2014 at 6:02 PM, Emil Velikov emil.l.veli...@gmail.com wrote: Because it's a great feature and we should not penalise people for doing out-of-tree builds. I don't think the commit message adds anything. With that removed, Reviewed-by: Matt Turner matts...@gmail.com