Re: [Mesa-dev] [PATCH] configure: Don't override user -g or -O options for debug builds

2014-07-14 Thread Ian Romanick
On 07/14/2014 01:41 PM, Matt Turner wrote: > On Mon, Jul 14, 2014 at 11:49 AM, Ian Romanick wrote: >> From: Ian Romanick >> >> I already pass '-ggdb3 -O1' or '-ggdb3 -Og' for CFLAGS, and I don't want >> configure to change them for me. >> >> Signed-off-by: Ian Romanick >> --- >> configure.ac |

Re: [Mesa-dev] [PATCH] configure: Don't override user -g or -O options for debug builds

2014-07-14 Thread Emil Velikov
On 14/07/14 19:49, Ian Romanick wrote: > From: Ian Romanick > > I already pass '-ggdb3 -O1' or '-ggdb3 -Og' for CFLAGS, and I don't want > configure to change them for me. > The topic is a rather messy and whatever we do there will always be a case where this breaks someone's setup/workflow. In

Re: [Mesa-dev] [PATCH] configure: Don't override user -g or -O options for debug builds

2014-07-14 Thread Marek Olšák
You can also just add -DDEBUG by yourself since you override the flags anyway (me too). Marek On Mon, Jul 14, 2014 at 8:49 PM, Ian Romanick wrote: > From: Ian Romanick > > I already pass '-ggdb3 -O1' or '-ggdb3 -Og' for CFLAGS, and I don't want > configure to change them for me. > > Signed-off-

Re: [Mesa-dev] [PATCH] configure: Don't override user -g or -O options for debug builds

2014-07-14 Thread Ilia Mirkin
On Mon, Jul 14, 2014 at 4:41 PM, Matt Turner wrote: > On Mon, Jul 14, 2014 at 11:49 AM, Ian Romanick wrote: >> From: Ian Romanick >> >> I already pass '-ggdb3 -O1' or '-ggdb3 -Og' for CFLAGS, and I don't want >> configure to change them for me. >> >> Signed-off-by: Ian Romanick >> --- >> confi

Re: [Mesa-dev] [PATCH] configure: Don't override user -g or -O options for debug builds

2014-07-14 Thread Matt Turner
On Mon, Jul 14, 2014 at 11:49 AM, Ian Romanick wrote: > From: Ian Romanick > > I already pass '-ggdb3 -O1' or '-ggdb3 -Og' for CFLAGS, and I don't want > configure to change them for me. > > Signed-off-by: Ian Romanick > --- > configure.ac | 14 -- > 1 file changed, 12 insertions(+)

Re: [Mesa-dev] [PATCH] configure: Don't override user -g or -O options for debug builds

2014-07-14 Thread Kenneth Graunke
On Monday, July 14, 2014 11:49:57 AM Ian Romanick wrote: > From: Ian Romanick > > I already pass '-ggdb3 -O1' or '-ggdb3 -Og' for CFLAGS, and I don't want > configure to change them for me. > > Signed-off-by: Ian Romanick > --- > configure.ac | 14 -- > 1 file changed, 12 insertion

[Mesa-dev] [PATCH] configure: Don't override user -g or -O options for debug builds

2014-07-14 Thread Ian Romanick
From: Ian Romanick I already pass '-ggdb3 -O1' or '-ggdb3 -Og' for CFLAGS, and I don't want configure to change them for me. Signed-off-by: Ian Romanick --- configure.ac | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 464621