Re: [Mesa-dev] [PATCH] draw: (trivial) fix clamping of viewport index

2014-06-23 Thread Ilia Mirkin
On Mon, Jun 23, 2014 at 4:13 PM, Ilia Mirkin wrote: > On Mon, Jun 23, 2014 at 4:08 PM, wrote: >> From: Roland Scheidegger >> >> The old logic would let all negative values go through unclamped, with >> potentially disastrous results (probably trying to fetch viewport values >> from random memor

Re: [Mesa-dev] [PATCH] draw: (trivial) fix clamping of viewport index

2014-06-23 Thread Jose Fonseca
LGTM. Jose From: srol...@vmware.com Sent: 23 June 2014 21:08 To: Jose Fonseca; mesa-dev@lists.freedesktop.org; imir...@alum.mit.edu Cc: Roland Scheidegger; 10.1 10.2 Subject: [PATCH] draw: (trivial) fix clamping of viewport index From: Roland Scheidegger

Re: [Mesa-dev] [PATCH] draw: (trivial) fix clamping of viewport index

2014-06-23 Thread Ilia Mirkin
On Mon, Jun 23, 2014 at 4:08 PM, wrote: > From: Roland Scheidegger > > The old logic would let all negative values go through unclamped, with > potentially disastrous results (probably trying to fetch viewport values > from random memory locations). GL has undefined rendering for vp indices > ou

[Mesa-dev] [PATCH] draw: (trivial) fix clamping of viewport index

2014-06-23 Thread sroland
From: Roland Scheidegger The old logic would let all negative values go through unclamped, with potentially disastrous results (probably trying to fetch viewport values from random memory locations). GL has undefined rendering for vp indices outside valid range but that's a bit too undefined... (