Re: [Mesa-dev] [PATCH] draw: don't clear the so targets until we stream out

2013-06-14 Thread Jose Fonseca
Sounds good to me. Jose - Original Message - > Since draw auto fetches the count from the buffers, we can't > just clear them on bind, we need to wait until the actual > stream out is performed. Otherwise the count for draw auto > will be zero. Plus is cleaner to have draw do it rather >

Re: [Mesa-dev] [PATCH] draw: don't clear the so targets until we stream out

2013-06-14 Thread Brian Paul
On 06/13/2013 07:01 PM, Zack Rusin wrote: Though I find stream output very confusing... I agree. I was digging a bit more and I think I was correct the first time. The D3D spec is very clear that "a buffer cannot be bound as both an input and an output at the same time", so I think the current

Re: [Mesa-dev] [PATCH] draw: don't clear the so targets until we stream out

2013-06-13 Thread Zack Rusin
> > Though I find stream output very confusing... > > I agree. I was digging a bit more and I think I was correct the first time. > The D3D spec is very clear that "a buffer cannot be bound as both an input > and an output at the same time", so I think the current behavior is correct, > or at leas

Re: [Mesa-dev] [PATCH] draw: don't clear the so targets until we stream out

2013-06-13 Thread Zack Rusin
> Though I find stream output very confusing... I agree. I was digging a bit more and I think I was correct the first time. The D3D spec is very clear that "a buffer cannot be bound as both an input and an output at the same time", so I think the current behavior is correct, or at least one of

Re: [Mesa-dev] [PATCH] draw: don't clear the so targets until we stream out

2013-06-13 Thread Roland Scheidegger
Am 14.06.2013 00:04, schrieb Zack Rusin: > Since draw auto fetches the count from the buffers, we can't > just clear them on bind, we need to wait until the actual > stream out is performed. Otherwise the count for draw auto > will be zero. Plus is cleaner to have draw do it rather > than drivers h

[Mesa-dev] [PATCH] draw: don't clear the so targets until we stream out

2013-06-13 Thread Zack Rusin
Since draw auto fetches the count from the buffers, we can't just clear them on bind, we need to wait until the actual stream out is performed. Otherwise the count for draw auto will be zero. Plus is cleaner to have draw do it rather than drivers having to mess with draw's internals. Signed-off-by