Re: [Mesa-dev] [PATCH] egl/dri2: dri2_make_current: Make sure display is initialized before using it

2016-07-19 Thread Nicolas Boichat
On Mon, Jul 18, 2016 at 4:37 PM, Emil Velikov wrote: > On 18 July 2016 at 04:19, Nicolas Boichat wrote: >> On Fri, Jul 15, 2016 at 9:03 PM, Emil Velikov >> wrote: >>> On 15 July 2016 at 09:28, Nicolas Boichat wrote: android.opengl.cts.WrapperTest#testGetIntegerv1 CTS test calls eglTe

Re: [Mesa-dev] [PATCH] egl/dri2: dri2_make_current: Make sure display is initialized before using it

2016-07-18 Thread Emil Velikov
On 18 July 2016 at 04:19, Nicolas Boichat wrote: > On Fri, Jul 15, 2016 at 9:03 PM, Emil Velikov > wrote: >> On 15 July 2016 at 09:28, Nicolas Boichat wrote: >>> android.opengl.cts.WrapperTest#testGetIntegerv1 CTS test calls >>> eglTerminate, followed by eglReleaseThread. In that case, the >>>

Re: [Mesa-dev] [PATCH] egl/dri2: dri2_make_current: Make sure display is initialized before using it

2016-07-17 Thread Nicolas Boichat
On Fri, Jul 15, 2016 at 9:03 PM, Emil Velikov wrote: > On 15 July 2016 at 09:28, Nicolas Boichat wrote: >> android.opengl.cts.WrapperTest#testGetIntegerv1 CTS test calls >> eglTerminate, followed by eglReleaseThread. In that case, the >> display will not be initialized when eglReleaseThread calls

Re: [Mesa-dev] [PATCH] egl/dri2: dri2_make_current: Make sure display is initialized before using it

2016-07-15 Thread Emil Velikov
On 15 July 2016 at 09:28, Nicolas Boichat wrote: > android.opengl.cts.WrapperTest#testGetIntegerv1 CTS test calls > eglTerminate, followed by eglReleaseThread. In that case, the > display will not be initialized when eglReleaseThread calls > MakeCurrent with NULL parameters, to unbind the context,

Re: [Mesa-dev] [PATCH] egl/dri2: dri2_make_current: Make sure display is initialized before using it

2016-07-15 Thread Rhys Kidd
Whilst I don't know that code as well as I'd like. It does get my Tested-by: Rhys Kidd for fixing that piglit on i965 ILK. Thanks for the two patches! On 15 July 2016 at 04:28, Nicolas Boichat wrote: > android.opengl.cts.WrapperTest#testGetIntegerv1 CTS test calls > eglTerminate, followed by

[Mesa-dev] [PATCH] egl/dri2: dri2_make_current: Make sure display is initialized before using it

2016-07-15 Thread Nicolas Boichat
android.opengl.cts.WrapperTest#testGetIntegerv1 CTS test calls eglTerminate, followed by eglReleaseThread. In that case, the display will not be initialized when eglReleaseThread calls MakeCurrent with NULL parameters, to unbind the context, which causes a a segfault in drv->API.MakeCurrent (dri2_m