Re: [Mesa-dev] [PATCH] egl/dri2: only destroy created objects

2017-08-30 Thread Emil Velikov
On 29 August 2017 at 10:51, Michael Olbrich wrote: > dri2_display_destroy may be called by dri2_initialize_wayland_drm() if > initialization fails. In this case, these objects may not be initialized. > Only if the wayland API had some basic NULL checks ... ;-) Thanks

Re: [Mesa-dev] [PATCH] egl/dri2: only destroy created objects

2017-08-29 Thread Tapani Pälli
On 08/30/2017 06:50 AM, Tapani Pälli wrote: On 08/29/2017 12:51 PM, Michael Olbrich wrote: dri2_display_destroy may be called by dri2_initialize_wayland_drm() if initialization fails. In this case, these objects may not be initialized. Same thing can happen with

Re: [Mesa-dev] [PATCH] egl/dri2: only destroy created objects

2017-08-29 Thread Tapani Pälli
On 08/29/2017 12:51 PM, Michael Olbrich wrote: dri2_display_destroy may be called by dri2_initialize_wayland_drm() if initialization fails. In this case, these objects may not be initialized. Same thing can happen with dri2_initialize_wayland_swrast, would be good to fix both at one go.

[Mesa-dev] [PATCH] egl/dri2: only destroy created objects

2017-08-29 Thread Michael Olbrich
dri2_display_destroy may be called by dri2_initialize_wayland_drm() if initialization fails. In this case, these objects may not be initialized. Signed-off-by: Michael Olbrich --- src/egl/drivers/dri2/egl_dri2.c | 9 ++--- 1 file changed, 6 insertions(+), 3