Re: [Mesa-dev] [PATCH] egl: Drop check for driver != NULL.

2015-06-09 Thread Rob Clark
On Tue, Jun 9, 2015 at 4:06 PM, Eric Anholt wrote: > Back in 2013, a patch was added (with 2 reviewers!) at the end of the > block to early exit the loop in this case, without noticing that the loop > already did. I added another early exit case, again without noticing, but > Rob caught me. Just

Re: [Mesa-dev] [PATCH] egl: Drop check for driver != NULL.

2015-06-09 Thread Ian Romanick
On 06/09/2015 01:06 PM, Eric Anholt wrote: > Back in 2013, a patch was added (with 2 reviewers!) at the end of the > block to early exit the loop in this case, without noticing that the loop > already did. I added another early exit case, again without noticing, but > Rob caught me. Just drop the

[Mesa-dev] [PATCH] egl: Drop check for driver != NULL.

2015-06-09 Thread Eric Anholt
Back in 2013, a patch was added (with 2 reviewers!) at the end of the block to early exit the loop in this case, without noticing that the loop already did. I added another early exit case, again without noticing, but Rob caught me. Just drop the loop condition that apparently surprises most of u