Re: [Mesa-dev] [PATCH] egl: Fix eglentrypoint.h sort order.

2018-11-02 Thread Emil Velikov
On Thu, 1 Nov 2018 at 16:54, Eric Engestrom wrote: > > On Thursday, 2018-11-01 17:37:57 +0100, Mathias Fröhlich wrote: > > Hi, > > > > On Thursday, 1 November 2018 17:28:48 CET Eric Engestrom wrote: > > > Pushed now, but travis still fails: > > > https://travis-ci.org/mesa3d/mesa/jobs/449405406 >

Re: [Mesa-dev] [PATCH] egl: Fix eglentrypoint.h sort order.

2018-11-01 Thread Eric Engestrom
On Thursday, 2018-11-01 17:37:57 +0100, Mathias Fröhlich wrote: > Hi, > > On Thursday, 1 November 2018 17:28:48 CET Eric Engestrom wrote: > > Pushed now, but travis still fails: > > https://travis-ci.org/mesa3d/mesa/jobs/449405406 > > > > I'm really confused here, because the LANG is now fixed, s

Re: [Mesa-dev] [PATCH] egl: Fix eglentrypoint.h sort order.

2018-11-01 Thread Mathias Fröhlich
Hi, On Thursday, 1 November 2018 17:28:48 CET Eric Engestrom wrote: > Pushed now, but travis still fails: > https://travis-ci.org/mesa3d/mesa/jobs/449405406 > > I'm really confused here, because the LANG is now fixed, so it shouldn't > behave differently on different environments? > > If anyone

Re: [Mesa-dev] [PATCH] egl: Fix eglentrypoint.h sort order.

2018-11-01 Thread Eric Engestrom
On Thursday, 2018-11-01 16:56:50 +0100, Mathias Fröhlich wrote: > Hi Michel, > > > > There seems to be a failure with the latest patches you pushed. > > > The patch fixes a failure with the sort order in egl symbols. > > > > Well, now it's broken with other locales. :) > > > > I guess src/egl/eg

Re: [Mesa-dev] [PATCH] egl: Fix eglentrypoint.h sort order.

2018-11-01 Thread Michel Dänzer
On 2018-11-01 4:56 p.m., Mathias Fröhlich wrote: > >>> There seems to be a failure with the latest patches you pushed. >>> The patch fixes a failure with the sort order in egl symbols. >> >> Well, now it's broken with other locales. :) >> >> I guess src/egl/egl-entrypoint-check itself should make

Re: [Mesa-dev] [PATCH] egl: Fix eglentrypoint.h sort order.

2018-11-01 Thread Mathias Fröhlich
Hi Michel, > > There seems to be a failure with the latest patches you pushed. > > The patch fixes a failure with the sort order in egl symbols. > > Well, now it's broken with other locales. :) > > I guess src/egl/egl-entrypoint-check itself should make sure sort runs > with locale settings resu

Re: [Mesa-dev] [PATCH] egl: Fix eglentrypoint.h sort order.

2018-11-01 Thread Michel Dänzer
Hi Mathias, On 2018-11-01 8:40 a.m., mathias.froehl...@gmx.net wrote: > From: Mathias Fröhlich > > Hi Emil, > > There seems to be a failure with the latest patches you pushed. > The patch fixes a failure with the sort order in egl symbols. Well, now it's broken with other locales. :) I gues

Re: [Mesa-dev] [PATCH] egl: Fix eglentrypoint.h sort order.

2018-11-01 Thread Eric Engestrom
On Thursday, 2018-11-01 08:40:08 +0100, mathias.froehl...@gmx.net wrote: > From: Mathias Fröhlich > > Hi Emil, > > There seems to be a failure with the latest patches you pushed. > The patch fixes a failure with the sort order in egl symbols. > > please review! > > FYI, I observed that the lat

Re: [Mesa-dev] [PATCH] egl: Fix eglentrypoint.h sort order.

2018-11-01 Thread Tapani Pälli
Reviewed-by: Tapani Pälli This fixes: dEQP-EGL.functional.get_proc_address.extension.egl_ext_device_base Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108617 On 11/1/18 9:40 AM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich Hi Emil, There seems to be a failure with the

[Mesa-dev] [PATCH] egl: Fix eglentrypoint.h sort order.

2018-11-01 Thread Mathias . Froehlich
From: Mathias Fröhlich Hi Emil, There seems to be a failure with the latest patches you pushed. The patch fixes a failure with the sort order in egl symbols. please review! FYI, I observed that the latest series that you sent for review differs a lot in the individual patches. Kind of looks li