Re: [Mesa-dev] [PATCH] egl: move Null check to eglGetSyncAttribKHR to prevent Segfault

2016-02-11 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Feb 3, 2016 at 12:06 AM, Dongwon Kim wrote: > Null-check on "*value" is currently done in > _eglGetSyncAttrib, which is after eglGetSyncAttribKHR > attempts to copy data at 'value' to 'attrib'. Segfault > is

[Mesa-dev] [PATCH] egl: move Null check to eglGetSyncAttribKHR to prevent Segfault

2016-02-02 Thread Dongwon Kim
Null-check on "*value" is currently done in _eglGetSyncAttrib, which is after eglGetSyncAttribKHR attempts to copy data at 'value' to 'attrib'. Segfault is enevitable if value==NULL in this case. Therefore, null-check should be moved to beginning of eglGetSyncAttribKHR to avoid any possible