[Mesa-dev] [PATCH] egl_dri2: fix aux buffer leak in drm platform

2012-04-10 Thread Mandeep Singh Baines
Keep a reference to any newly allocated aux buffers to avoid re-allocating for every st_framebuffer_validate() (i.e. leaking). Signed-off-by: Mandeep Singh Baines Cc: Ander Conselvan de Oliveira Cc: Benjamin Franzke Cc: Kristian Hogsberg Cc: David Reveman Cc: Stephane Marchesin --- src/egl/

Re: [Mesa-dev] [PATCH] egl_dri2: fix aux buffer leak in drm platform

2012-04-10 Thread Mandeep Singh Baines
On Tue, Apr 10, 2012 at 4:02 PM, Kristian Høgsberg wrote: > On Tue, Apr 10, 2012 at 6:30 PM, Mandeep Baines > wrote: >> Attached is the test case I've been using. > > Nice, I've been meaning to update eglkms.c to also demonstrate > pageflipping.  Do you mind if I commit your version? > Attached

Re: [Mesa-dev] [PATCH] egl_dri2: fix aux buffer leak in drm platform

2012-04-10 Thread Kristian Høgsberg
On Tue, Apr 10, 2012 at 5:48 PM, Mandeep Singh Baines wrote: > Keep a reference to any newly allocated aux buffers to avoid > re-allocating for every st_framebuffer_validate() (i.e. leaking). Oops, yes, that's obviously how it was meant to work. I never used a depth buffer in any of the test cas

Re: [Mesa-dev] [PATCH] egl_dri2: fix aux buffer leak in drm platform

2012-04-10 Thread Mandeep Singh Baines
On Tue, Apr 10, 2012 at 4:02 PM, Kristian Høgsberg wrote: > On Tue, Apr 10, 2012 at 6:30 PM, Mandeep Baines > wrote: >> Attached is the test case I've been using. > > Nice, I've been meaning to update eglkms.c to also demonstrate > pageflipping.  Do you mind if I commit your version? > Sure. Si

Re: [Mesa-dev] [PATCH] egl_dri2: fix aux buffer leak in drm platform

2012-04-10 Thread Kristian Høgsberg
On Tue, Apr 10, 2012 at 6:30 PM, Mandeep Baines wrote: > Attached is the test case I've been using. Nice, I've been meaning to update eglkms.c to also demonstrate pageflipping. Do you mind if I commit your version? Kristian > On Tue, Apr 10, 2012 at 3:26 PM,   wrote: >> From: Mandeep Singh Bai

Re: [Mesa-dev] [PATCH] egl_dri2: fix aux buffer leak in drm platform

2012-04-10 Thread Mandeep Baines
Attached is the test case I've been using. On Tue, Apr 10, 2012 at 3:26 PM, wrote: > From: Mandeep Singh Baines > > Keep a reference to any newly allocated aux buffers to avoid > re-allocating for every st_framebuffer_validate() (i.e. leaking). > > Signed-off-by: Mandeep Singh Baines > Cc: And

[Mesa-dev] [PATCH] egl_dri2: fix aux buffer leak in drm platform

2012-04-10 Thread mandeep . baines
From: Mandeep Singh Baines Keep a reference to any newly allocated aux buffers to avoid re-allocating for every st_framebuffer_validate() (i.e. leaking). Signed-off-by: Mandeep Singh Baines Cc: Ander Conselvan de Oliveira Cc: Benjamin Franzke Cc: Kristian Hogsberg Cc: David Reveman Cc: Step