Re: [Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format (v2)

2017-12-09 Thread Denis Pauk
Hi! As for me, patch is too minor and be in future 18.+ release is enough, As i know application can't cause segfault by public API by this path(only by private api). On Tue, Nov 28, 2017 at 4:48 PM, Marek Olšák wrote: > On Tue, Nov 28, 2017 at 3:46 PM, Emil Velikov

Re: [Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format (v2)

2017-11-28 Thread Marek Olšák
On Tue, Nov 28, 2017 at 3:46 PM, Emil Velikov wrote: > On 28 November 2017 at 13:44, Andres Gomez wrote: >> Denis, this looks like a good candidate to nominate for inclusion in >> the 17.2 stable queue. >> >> What do you think? >> > Patch seems safe,

Re: [Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format (v2)

2017-11-28 Thread Emil Velikov
On 28 November 2017 at 13:44, Andres Gomez wrote: > Denis, this looks like a good candidate to nominate for inclusion in > the 17.2 stable queue. > > What do you think? > Patch seems safe, but it's a bit meh since it says "segfault" without specifying any usecase. IIRC the only

Re: [Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format (v2)

2017-11-28 Thread Andres Gomez
Denis, this looks like a good candidate to nominate for inclusion in the 17.2 stable queue. What do you think? On Tue, 2017-09-12 at 23:38 +0300, Denis Pauk wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102552 > > v2: Patch cleanup proposed by Nicolai Hähnle. > * deleted

Re: [Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format (v2)

2017-09-13 Thread Denis Pauk
Thank you. I have closed https://bugs.freedesktop.org/show_bug.cgi?id=102552 Best regards, Denis. On Sep 14, 2017 2:01 AM, "Marek Olšák" wrote: > I pushed the patch. Thanks. > > Marek > > On Wed, Sep 13, 2017 at 9:27 PM, Denis Pauk

Re: [Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format (v2)

2017-09-13 Thread Marek Olšák
I pushed the patch. Thanks. Marek On Wed, Sep 13, 2017 at 9:27 PM, Denis Pauk wrote: > Could you please commit this changes? > > I have not found what i need to do next after recieve "approve" for changes > in https://www.mesa3d.org/submittingpatches.html#reviewing. > Do i

Re: [Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format (v2)

2017-09-13 Thread Emil Velikov
On 13 September 2017 at 20:27, Denis Pauk wrote: > Could you please commit this changes? > > I have not found what i need to do next after recieve "approve" for changes > in https://www.mesa3d.org/submittingpatches.html#reviewing. > Do i need to send new mail with

Re: [Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format (v2)

2017-09-13 Thread Denis Pauk
Could you please commit this changes? I have not found what i need to do next after recieve "approve" for changes in https://www.mesa3d.org/submittingpatches.html#reviewing. Do i need to send new mail with "Reviewed-by: " mark? On Wed, Sep 13, 2017 at 6:36 PM, Marek Olšák

Re: [Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format (v2)

2017-09-13 Thread Marek Olšák
I've changed my mind. The patch is OK: Reviewed-by: Marek Olšák Marek On Wed, Sep 13, 2017 at 4:45 PM, Denis Pauk wrote: > What do you think about replace all checks in patch to asserts? > > > Best regards, > Denis. > > On Sep 13,

Re: [Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format (v2)

2017-09-13 Thread Denis Pauk
What do you think about replace all checks in patch to asserts? Best regards, Denis. On Sep 13, 2017 1:00 PM, "Marek Olšák" wrote: > On Wed, Sep 13, 2017 at 6:54 AM, Денис Паук wrote: > > Do you mean delete check in u_format.c::

Re: [Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format (v2)

2017-09-13 Thread Marek Olšák
On Wed, Sep 13, 2017 at 6:54 AM, Денис Паук wrote: > Do you mean delete check in u_format.c:: util_format_is_supported? Could you > please explain more? I mean delete everything. Invalid formats shouldn't be passed to pipe_screen::is_format_supported. The code doing it

Re: [Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format (v2)

2017-09-13 Thread Denis Pauk
This only example of code, that we can use for check is_format_supported call. Its not real world code. Best regards, Denis. On Sep 13, 2017 11:15 AM, "Nicolai Hähnle" wrote: > On 13.09.2017 08:26, Denis Pauk wrote: > >> Little additional note: >> >> This

Re: [Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format (v2)

2017-09-13 Thread Nicolai Hähnle
On 13.09.2017 08:26, Denis Pauk wrote: Little additional note: This checks related to possible issue with such kind of supported format check in external code: for(int i=0; iis_format_supported(pscreen, i, PIPE_TEXTURE_2D, 0, PIPE_BIND_SAMPLER_VIEW); } - When we have segfault

Re: [Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format (v2)

2017-09-13 Thread Denis Pauk
Little additional note: This checks related to possible issue with such kind of supported format check in external code: for(int i=0; iis_format_supported(pscreen, i, PIPE_TEXTURE_2D, 0, PIPE_BIND_SAMPLER_VIEW); } - When we have segfault with: 73, 78, 79, 80, 81, 86 (holes in enum

Re: [Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format (v2)

2017-09-12 Thread Денис Паук
Do you mean delete check in u_format.c:: util_format_is_supported? Could you please explain more? On Wed, Sep 13, 2017 at 1:32 AM, Marek Olšák wrote: > On Wed, Sep 13, 2017 at 12:31 AM, Marek Olšák wrote: > > I think we shouldn't be getting PIPE_FORMAT_COUNT

Re: [Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format (v2)

2017-09-12 Thread Marek Olšák
On Wed, Sep 13, 2017 at 12:31 AM, Marek Olšák wrote: > I think we shouldn't be getting PIPE_FORMAT_COUNT in > is_format_supported in the first place, and therefore drivers don't > have to work around it. Or any other invalid formats, for that matter. Marek > > Marek > > On

Re: [Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format (v2)

2017-09-12 Thread Marek Olšák
I think we shouldn't be getting PIPE_FORMAT_COUNT in is_format_supported in the first place, and therefore drivers don't have to work around it. Marek On Tue, Sep 12, 2017 at 10:38 PM, Denis Pauk wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102552 > >

[Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format (v2)

2017-09-12 Thread Denis Pauk
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102552 v2: Patch cleanup proposed by Nicolai Hähnle. * deleted changes in si_translate_texformat. Cc: Nicolai Hähnle Cc: Ilia Mirkin --- src/gallium/auxiliary/util/u_format.c| 4