Re: [Mesa-dev] [PATCH] gallium/docs: clarify set_sampler_views

2019-03-15 Thread Rob Clark
On Fri, Mar 15, 2019 at 8:21 AM Axel Davy wrote: > > On 15/03/2019 13:12, Rob Clark wrote: > > On Fri, Mar 15, 2019 at 3:49 AM Axel Davy wrote: > > >> To my knowledge, the semantic of set_sampler_views was changed two years > >> ago, and that caused some issues: > >> https://github.com/iXit/Mesa-

Re: [Mesa-dev] [PATCH] gallium/docs: clarify set_sampler_views

2019-03-15 Thread Ilia Mirkin
On Fri, Mar 15, 2019 at 8:21 AM Axel Davy wrote: > This is compatible with what I said. Nouveau determines the minimum > number of samplers actually needed > by the current shader, and internally unbinds those above (and rebinds > if needed by new shader). The things nouveau does today aren't nec

Re: [Mesa-dev] [PATCH] gallium/docs: clarify set_sampler_views

2019-03-15 Thread Axel Davy
On 15/03/2019 13:12, Rob Clark wrote: On Fri, Mar 15, 2019 at 3:49 AM Axel Davy wrote: On 15/03/2019 03:12, Rob Clark wrote: On Thu, Mar 14, 2019 at 9:58 PM Roland Scheidegger wrote: Am 15.03.19 um 02:18 schrieb Rob Clark: On Thu, Mar 14, 2019 at 8:28 PM Roland Scheidegger wrote: Am 14.03

Re: [Mesa-dev] [PATCH] gallium/docs: clarify set_sampler_views

2019-03-15 Thread Rob Clark
On Fri, Mar 15, 2019 at 3:49 AM Axel Davy wrote: > > On 15/03/2019 03:12, Rob Clark wrote: > > On Thu, Mar 14, 2019 at 9:58 PM Roland Scheidegger > > wrote: > >> Am 15.03.19 um 02:18 schrieb Rob Clark: > >>> On Thu, Mar 14, 2019 at 8:28 PM Roland Scheidegger > >>> wrote: > Am 14.03.19 um

Re: [Mesa-dev] [PATCH] gallium/docs: clarify set_sampler_views

2019-03-15 Thread Axel Davy
On 15/03/2019 03:12, Rob Clark wrote: On Thu, Mar 14, 2019 at 9:58 PM Roland Scheidegger wrote: Am 15.03.19 um 02:18 schrieb Rob Clark: On Thu, Mar 14, 2019 at 8:28 PM Roland Scheidegger wrote: Am 14.03.19 um 22:06 schrieb Rob Clark: On Thu, Mar 14, 2019 at 3:58 PM Roland Scheidegger wrote

Re: [Mesa-dev] [PATCH] gallium/docs: clarify set_sampler_views

2019-03-14 Thread Rob Clark
On Thu, Mar 14, 2019 at 9:58 PM Roland Scheidegger wrote: > > Am 15.03.19 um 02:18 schrieb Rob Clark: > > On Thu, Mar 14, 2019 at 8:28 PM Roland Scheidegger > > wrote: > >> > >> Am 14.03.19 um 22:06 schrieb Rob Clark: > >>> On Thu, Mar 14, 2019 at 3:58 PM Roland Scheidegger > >>> wrote: >

Re: [Mesa-dev] [PATCH] gallium/docs: clarify set_sampler_views

2019-03-14 Thread Roland Scheidegger
Am 15.03.19 um 02:18 schrieb Rob Clark: > On Thu, Mar 14, 2019 at 8:28 PM Roland Scheidegger wrote: >> >> Am 14.03.19 um 22:06 schrieb Rob Clark: >>> On Thu, Mar 14, 2019 at 3:58 PM Roland Scheidegger >>> wrote: Am 14.03.19 um 14:13 schrieb Rob Clark: > On Tue, Mar 12, 2019 at 1:59

Re: [Mesa-dev] [PATCH] gallium/docs: clarify set_sampler_views

2019-03-14 Thread Rob Clark
On Thu, Mar 14, 2019 at 8:28 PM Roland Scheidegger wrote: > > Am 14.03.19 um 22:06 schrieb Rob Clark: > > On Thu, Mar 14, 2019 at 3:58 PM Roland Scheidegger > > wrote: > >> > >> Am 14.03.19 um 14:13 schrieb Rob Clark: > >>> On Tue, Mar 12, 2019 at 1:59 PM Roland Scheidegger > >>> wrote: >

Re: [Mesa-dev] [PATCH] gallium/docs: clarify set_sampler_views

2019-03-14 Thread Roland Scheidegger
Am 14.03.19 um 22:06 schrieb Rob Clark: > On Thu, Mar 14, 2019 at 3:58 PM Roland Scheidegger wrote: >> >> Am 14.03.19 um 14:13 schrieb Rob Clark: >>> On Tue, Mar 12, 2019 at 1:59 PM Roland Scheidegger >>> wrote: Am 12.03.19 um 16:16 schrieb Rob Clark: > This previously was not call

Re: [Mesa-dev] [PATCH] gallium/docs: clarify set_sampler_views

2019-03-14 Thread Rob Clark
On Thu, Mar 14, 2019 at 3:58 PM Roland Scheidegger wrote: > > Am 14.03.19 um 14:13 schrieb Rob Clark: > > On Tue, Mar 12, 2019 at 1:59 PM Roland Scheidegger > > wrote: > >> > >> Am 12.03.19 um 16:16 schrieb Rob Clark: > >>> This previously was not called out clearly, but based on a survey of the

Re: [Mesa-dev] [PATCH] gallium/docs: clarify set_sampler_views

2019-03-14 Thread Roland Scheidegger
Am 14.03.19 um 14:13 schrieb Rob Clark: > On Tue, Mar 12, 2019 at 1:59 PM Roland Scheidegger wrote: >> >> Am 12.03.19 um 16:16 schrieb Rob Clark: >>> This previously was not called out clearly, but based on a survey of the >>> code, it seems the expected behavior is to release the reference to any

Re: [Mesa-dev] [PATCH] gallium/docs: clarify set_sampler_views

2019-03-14 Thread Rob Clark
On Tue, Mar 12, 2019 at 1:59 PM Roland Scheidegger wrote: > > Am 12.03.19 um 16:16 schrieb Rob Clark: > > This previously was not called out clearly, but based on a survey of the > > code, it seems the expected behavior is to release the reference to any > > sampler views beyond the new range bein

Re: [Mesa-dev] [PATCH] gallium/docs: clarify set_sampler_views

2019-03-13 Thread Rob Clark
On Wed, Mar 13, 2019 at 11:37 AM Roland Scheidegger wrote: > > Am 12.03.19 um 22:48 schrieb Rob Clark: > > On Tue, Mar 12, 2019 at 1:59 PM Roland Scheidegger > > wrote: > >> > >> Am 12.03.19 um 16:16 schrieb Rob Clark: > >>> This previously was not called out clearly, but based on a survey of th

Re: [Mesa-dev] [PATCH] gallium/docs: clarify set_sampler_views

2019-03-13 Thread Roland Scheidegger
Am 12.03.19 um 22:48 schrieb Rob Clark: > On Tue, Mar 12, 2019 at 1:59 PM Roland Scheidegger wrote: >> >> Am 12.03.19 um 16:16 schrieb Rob Clark: >>> This previously was not called out clearly, but based on a survey of the >>> code, it seems the expected behavior is to release the reference to any

Re: [Mesa-dev] [PATCH] gallium/docs: clarify set_sampler_views

2019-03-12 Thread Rob Clark
On Tue, Mar 12, 2019 at 1:59 PM Roland Scheidegger wrote: > > Am 12.03.19 um 16:16 schrieb Rob Clark: > > This previously was not called out clearly, but based on a survey of the > > code, it seems the expected behavior is to release the reference to any > > sampler views beyond the new range bein

Re: [Mesa-dev] [PATCH] gallium/docs: clarify set_sampler_views

2019-03-12 Thread Roland Scheidegger
Am 12.03.19 um 16:16 schrieb Rob Clark: > This previously was not called out clearly, but based on a survey of the > code, it seems the expected behavior is to release the reference to any > sampler views beyond the new range being bound. That isn't really true. This was designed to work like d3d1

[Mesa-dev] [PATCH] gallium/docs: clarify set_sampler_views

2019-03-12 Thread Rob Clark
This previously was not called out clearly, but based on a survey of the code, it seems the expected behavior is to release the reference to any sampler views beyond the new range being bound. I think radeonsi and freedreno were the only ones not doing this. Which could probably temporarily leak