Re: [Mesa-dev] [PATCH] gallium/tests/trivial: fix viewport depth transform

2018-02-28 Thread Mathias Fröhlich
Hi, On Thursday, 1 March 2018 04:00:15 CET Roland Scheidegger wrote: > Am 01.03.2018 um 03:28 schrieb Ilia Mirkin: > > On Wed, Feb 28, 2018 at 8:42 PM, Roland Scheidegger wrote: [...] > > Is this not the correct behavior? Or is it undefined what happens > > outside of 0..1? > I can't really see

Re: [Mesa-dev] [PATCH] gallium/tests/trivial: fix viewport depth transform

2018-02-28 Thread Roland Scheidegger
Am 01.03.2018 um 03:28 schrieb Ilia Mirkin: > On Wed, Feb 28, 2018 at 8:42 PM, Roland Scheidegger > wrote: >> I suppose that's ok (and safer), albeit I'm not sure why it wouldn't >> work with nv50. >> Depth clip is enabled, yes, but I can't see why the produced values >> wouldn't be inside the vi

Re: [Mesa-dev] [PATCH] gallium/tests/trivial: fix viewport depth transform

2018-02-28 Thread Ilia Mirkin
On Wed, Feb 28, 2018 at 8:42 PM, Roland Scheidegger wrote: > I suppose that's ok (and safer), albeit I'm not sure why it wouldn't > work with nv50. > Depth clip is enabled, yes, but I can't see why the produced values > wouldn't be inside the view volume (which is defined by the near/far > values

Re: [Mesa-dev] [PATCH] gallium/tests/trivial: fix viewport depth transform

2018-02-28 Thread Roland Scheidegger
I suppose that's ok (and safer), albeit I'm not sure why it wouldn't work with nv50. Depth clip is enabled, yes, but I can't see why the produced values wouldn't be inside the view volume (which is defined by the near/far values for z). Granted values outside [0,1] are not permitted by standard GL,

[Mesa-dev] [PATCH] gallium/tests/trivial: fix viewport depth transform

2018-02-28 Thread Ilia Mirkin
These were getting mapped off into outer space, which would cause nv50 and nvc0 to clip the primitives (as depth_clip was enabled). Oddly enough, it worked with nv30 and llvmpipe though. Perhaps their frustrum clipping rules are a bit different? Signed-off-by: Ilia Mirkin --- src/gallium/tests/