Re: [Mesa-dev] [PATCH] gallium: Fix blend color alignment for 32-bit systems

2016-07-13 Thread Chuck Atkins
(I've been out on vacation for the past week and a half so sorry it took so long for me to get to this) I'm okay with reverting the initial commit entirely. At the time I was thinking about the alignment in terms of C++ memory allocation, in which case the struct would be allocated with new and

Re: [Mesa-dev] [PATCH] gallium: Fix blend color alignment for 32-bit systems

2016-07-13 Thread Nicolai Hähnle
On 12.07.2016 15:44, Roland Scheidegger wrote: Am 12.07.2016 um 13:40 schrieb Nicolai Hähnle: From: Nicolai Hähnle This fixes a regression introduced by commit d8d6091a8. Heap allocations may be only 8-byte aligned on 32-bit system, and so having members with 16-byte

Re: [Mesa-dev] [PATCH] gallium: Fix blend color alignment for 32-bit systems

2016-07-12 Thread Roland Scheidegger
Am 12.07.2016 um 13:40 schrieb Nicolai Hähnle: > From: Nicolai Hähnle > > This fixes a regression introduced by commit d8d6091a8. > > Heap allocations may be only 8-byte aligned on 32-bit system, and so having > members with 16-byte alignment (such as in the case where

Re: [Mesa-dev] [PATCH] gallium: Fix blend color alignment for 32-bit systems

2016-07-12 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Jul 12, 2016 at 1:40 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This fixes a regression introduced by commit d8d6091a8. > > Heap allocations may be only 8-byte aligned on 32-bit

[Mesa-dev] [PATCH] gallium: Fix blend color alignment for 32-bit systems

2016-07-12 Thread Nicolai Hähnle
From: Nicolai Hähnle This fixes a regression introduced by commit d8d6091a8. Heap allocations may be only 8-byte aligned on 32-bit system, and so having members with 16-byte alignment (such as in the case where pipe_blend_color is embedded in radeonsi's si_context) is