Re: [Mesa-dev] [PATCH] gallium: initialize ureg_dst::Invariant bit

2018-07-25 Thread Emil Velikov
On 25 July 2018 at 16:28, Erik Faye-Lund wrote: > When this bit was added, it seems the some initialization code > was omitted by mistake. > > Since stack-variables have kinda random contents, and we don't > zero initialize the whole struct in these code-paths, we end up > getting random-ish value

[Mesa-dev] [PATCH] gallium: initialize ureg_dst::Invariant bit

2018-07-25 Thread Erik Faye-Lund
When this bit was added, it seems the some initialization code was omitted by mistake. Since stack-variables have kinda random contents, and we don't zero initialize the whole struct in these code-paths, we end up getting random-ish values for this bit. Spotted by Coverity in the following CIDs: