Re: [Mesa-dev] [PATCH] gallium: remove pipe_blend_state::dither

2018-01-31 Thread Marek Olšák
On Jan 31, 2018 11:14 PM, "Eric Anholt" wrote: Marek Olšák writes: > From: Marek Olšák > > very few drivers actually implement it. I disagree. If the hardware supports it and the API supports it, then we should support it, too. I've

Re: [Mesa-dev] [PATCH] gallium: remove pipe_blend_state::dither

2018-01-31 Thread Eric Anholt
Marek Olšák writes: > From: Marek Olšák > > very few drivers actually implement it. I disagree. If the hardware supports it and the API supports it, then we should support it, too. I've got a branch around somewhere for vc4 dithering. signature.asc

Re: [Mesa-dev] [PATCH] gallium: remove pipe_blend_state::dither

2018-01-31 Thread Ilia Mirkin
On Wed, Jan 31, 2018 at 2:59 PM, Marek Olšák wrote: > On Wed, Jan 31, 2018 at 8:58 PM, Ilia Mirkin wrote: >> nine uses it, GL uses it, a bunch of drivers implement it ... why is >> it being removed? > > very few drivers actually implement it. nv30,

Re: [Mesa-dev] [PATCH] gallium: remove pipe_blend_state::dither

2018-01-31 Thread Marek Olšák
On Wed, Jan 31, 2018 at 8:58 PM, Ilia Mirkin wrote: > nine uses it, GL uses it, a bunch of drivers implement it ... why is > it being removed? very few drivers actually implement it. Marek ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH] gallium: remove pipe_blend_state::dither

2018-01-31 Thread Ilia Mirkin
nine uses it, GL uses it, a bunch of drivers implement it ... why is it being removed? On Wed, Jan 31, 2018 at 2:55 PM, Marek Olšák wrote: > From: Marek Olšák > > very few drivers actually implement it. > --- > src/gallium/auxiliary/util/u_dump_state.c

[Mesa-dev] [PATCH] gallium: remove pipe_blend_state::dither

2018-01-31 Thread Marek Olšák
From: Marek Olšák very few drivers actually implement it. --- src/gallium/auxiliary/util/u_dump_state.c | 1 - src/gallium/auxiliary/vl/vl_compositor.c | 1 - src/gallium/auxiliary/vl/vl_idct.c | 1 - src/gallium/auxiliary/vl/vl_mc.c