Re: [Mesa-dev] [PATCH] gallivm: Use the LLVM's C disassembly interface.

2015-05-29 Thread Jose Fonseca
On 28/05/15 19:26, Roland Scheidegger wrote: Looks ok, it's massively simpler and shouldn't break as often. Reviewed-by: Roland Scheidegger Am 28.05.2015 um 17:57 schrieb Jose Fonseca: It doesn't do everything we want. In particular it doesn't allow to detect jumps or return opcodes. Curren

Re: [Mesa-dev] [PATCH] gallivm: Use the LLVM's C disassembly interface.

2015-05-28 Thread Roland Scheidegger
Looks ok, it's massively simpler and shouldn't break as often. Reviewed-by: Roland Scheidegger Am 28.05.2015 um 17:57 schrieb Jose Fonseca: > It doesn't do everything we want. In particular it doesn't allow to > detect jumps or return opcodes. Currently we detect the x86's RET > opcode. > > E

[Mesa-dev] [PATCH] gallivm: Use the LLVM's C disassembly interface.

2015-05-28 Thread Jose Fonseca
It doesn't do everything we want. In particular it doesn't allow to detect jumps or return opcodes. Currently we detect the x86's RET opcode. Even though it's worse for LLVM 3.3, it's an improvement for LLVM 3.7, which was totally busted. --- scons/llvm.py | 4