Re: [Mesa-dev] [PATCH] gallivm: don't use vector selects with llvm 3.7

2016-04-17 Thread Roland Scheidegger
Am 18.04.2016 um 00:31 schrieb Emil Velikov: > Hi gents, > > On 17 April 2016 at 10:06, Jose Fonseca wrote: >> On 16/04/16 22:30, srol...@vmware.com wrote: >>> >>> From: Roland Scheidegger >>> >>> llvm 3.7 sometimes simply miscompiles vector selects. >> >> >> Reviewed-by: Jose Fonseca >> > We w

Re: [Mesa-dev] [PATCH] gallivm: don't use vector selects with llvm 3.7

2016-04-17 Thread Emil Velikov
Hi gents, On 17 April 2016 at 10:06, Jose Fonseca wrote: > On 16/04/16 22:30, srol...@vmware.com wrote: >> >> From: Roland Scheidegger >> >> llvm 3.7 sometimes simply miscompiles vector selects. > > > Reviewed-by: Jose Fonseca > We want this for stable (11.1/11.2), correct ? -Emil

Re: [Mesa-dev] [PATCH] gallivm: don't use vector selects with llvm 3.7

2016-04-17 Thread Roland Scheidegger
Am 17.04.2016 um 11:06 schrieb Jose Fonseca: > On 16/04/16 22:30, srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> llvm 3.7 sometimes simply miscompiles vector selects. > > Reviewed-by: Jose Fonseca > >> See https://bugs.freedesktop.org/show_bug.cgi?id=94972 > > Great detective work

Re: [Mesa-dev] [PATCH] gallivm: don't use vector selects with llvm 3.7

2016-04-17 Thread Jose Fonseca
On 16/04/16 22:30, srol...@vmware.com wrote: From: Roland Scheidegger llvm 3.7 sometimes simply miscompiles vector selects. Reviewed-by: Jose Fonseca See https://bugs.freedesktop.org/show_bug.cgi?id=94972 Great detective work. I think you should make a LLVM test case out of the IR on th

[Mesa-dev] [PATCH] gallivm: don't use vector selects with llvm 3.7

2016-04-16 Thread sroland
From: Roland Scheidegger llvm 3.7 sometimes simply miscompiles vector selects. See https://bugs.freedesktop.org/show_bug.cgi?id=94972 --- src/gallium/auxiliary/gallivm/lp_bld_logic.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_