Re: [Mesa-dev] [PATCH] gallivm: fix crash in lp_sampler_static_state()

2012-08-10 Thread Brian Paul
On 08/10/2012 09:38 AM, Jose Fonseca wrote: Is a view with a NULL texture really possible? Probably not, but I'd rather be extra safe. -Brian ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa

Re: [Mesa-dev] [PATCH] gallivm: fix crash in lp_sampler_static_state()

2012-08-10 Thread Jose Fonseca
Is a view with a NULL texture really possible? Otherwise Reviewed-by: Jose Fonseca Jose - Original Message - > Fixes WebGL conformance/uniforms/uniform-default-values.html crash. > > We need to check for the null view pointer before accessing > view->texture. > > Fixes http://bugs.f

[Mesa-dev] [PATCH] gallivm: fix crash in lp_sampler_static_state()

2012-08-10 Thread Brian Paul
Fixes WebGL conformance/uniforms/uniform-default-values.html crash. We need to check for the null view pointer before accessing view->texture. Fixes http://bugs.freedesktop.org/show_bug.cgi?id=53317 Note: This is a candidate for the 8.0 branch. --- src/gallium/auxiliary/gallivm/lp_bld_sample.c