Re: [Mesa-dev] [PATCH] gallivm: make sampling more robust against bogus coordinates

Am 25.04.2016 um 15:44 schrieb Jose Fonseca: > Looks good AFAICT. Can there be an impact in performance? Yes, but I think it should be fairly minimal for the affected modes - at least int compare / min instructions are cheap (too bad we only have unsigned min with/max with sse41 but not compare).

Re: [Mesa-dev] [PATCH] gallivm: make sampling more robust against bogus coordinates

Looks good AFAICT. Can there be an impact in performance? Reviewed-by: Jose Fonseca I also think we should have piglit testcases for these things. Would it be easy to modify one of the existing textrwap to use Nans? We need to use BGRA8 and something else (e.g.,

Re: [Mesa-dev] [PATCH] gallivm: make sampling more robust against bogus coordinates

Tested-by: Bruce Cherniak On 4/22/16, 8:33 AM, "mesa-dev on behalf of srol...@vmware.com" wrote: >From: Roland Scheidegger > >Some cases (especially these using fract for

[Mesa-dev] [PATCH] gallivm: make sampling more robust against bogus coordinates

From: Roland Scheidegger Some cases (especially these using fract for coord wrapping) did not handle NaNs (or Infs) correctly - the following code assumed the fract result could not be outside [0,1], but if the input is a NaN (or +-Inf) the fract result was NaN - which then