Re: [Mesa-dev] [PATCH] glcpp: Don't use alternation in the lookahead for empty pragmas.

2014-08-22 Thread Carl Worth
Kenneth Graunke kenn...@whitecape.org writes: Erm. Shouldn't there be a star here? ^^^ Yikes! I don't know which is more embarrassing. The regression that I committed that showed I didn't take enough care in running piglit, or this patch which I submitted to fix it which showed I took even less

[Mesa-dev] [PATCH] glcpp: Don't use alternation in the lookahead for empty pragmas.

2014-08-18 Thread Carl Worth
We've found that there's a buffer overrun bug in flex that's triggered by using alternation in a lookahead pattern. Fortunately, we don't need to match the exact {NEWLINE} expression to detect an empty pragma. It suffices to verify that there are no non-space characters before any newline

Re: [Mesa-dev] [PATCH] glcpp: Don't use alternation in the lookahead for empty pragmas.

2014-08-18 Thread Kenneth Graunke
On Monday, August 18, 2014 11:49:13 AM Carl Worth wrote: We've found that there's a buffer overrun bug in flex that's triggered by using alternation in a lookahead pattern. Fortunately, we don't need to match the exact {NEWLINE} expression to detect an empty pragma. It suffices to verify