Re: [Mesa-dev] [PATCH] glcpp: Reject #version after the version has been resolved.

2014-01-31 Thread Kenneth Graunke
On 01/30/2014 02:24 PM, Carl Worth wrote: > Matt Turner writes: >> +if (parser->version_resolved) { >> +glcpp_error(& @1, parser, "#version after >> version is resolved"); > > The phrasing "after version is resolved" makes a lot of sense from the > point-of-view of

Re: [Mesa-dev] [PATCH] glcpp: Reject #version after the version has been resolved.

2014-01-30 Thread Carl Worth
Matt Turner writes: > + if (parser->version_resolved) { > + glcpp_error(& @1, parser, "#version after > version is resolved"); The phrasing "after version is resolved" makes a lot of sense from the point-of-view of the implementation, but it's not ideal for guiding

Re: [Mesa-dev] [PATCH] glcpp: Reject #version after the version has been resolved.

2014-01-29 Thread Jordan Justen
Reviewed-by: Jordan Justen On Wed, Jan 29, 2014 at 12:48 PM, Matt Turner wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=74166 > --- > src/glsl/glcpp/glcpp-parse.y | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/glsl/glcpp/glcpp-parse.y b/src/glsl/glcpp/glcpp-

[Mesa-dev] [PATCH] glcpp: Reject #version after the version has been resolved.

2014-01-29 Thread Matt Turner
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=74166 --- src/glsl/glcpp/glcpp-parse.y | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/glsl/glcpp/glcpp-parse.y b/src/glsl/glcpp/glcpp-parse.y index 17bc649..4dba051 100644 --- a/src/glsl/glcpp/glcpp-parse.y +++ b/src/glsl/glcpp/