Re: [Mesa-dev] [PATCH] glsl/ast: don't crash when func_name is NULL

2016-06-06 Thread Dave Airlie
On 7 June 2016 at 00:17, Iago Toral wrote: > I guess this makes sense: > Reviewed-by: Iago Toral Quiroga > Out of curiosity, in which case do we get here and can't find a function > name? The test does something illegal earlier, but we keep parsing it, the case we end up here is with id->oper be

Re: [Mesa-dev] [PATCH] glsl/ast: don't crash when func_name is NULL

2016-06-06 Thread Iago Toral
I guess this makes sense: Reviewed-by: Iago Toral Quiroga From: Dave Airlie > > This fixes a crash in > GL43-CTS.shader_subroutine.subroutines_not_allowed_as_variables_constructors_and_argument_or_return_types > > If we can't find the func_name in one of these paths, > we have emitted an earlie

[Mesa-dev] [PATCH] glsl/ast: don't crash when func_name is NULL

2016-06-05 Thread Dave Airlie
From: Dave Airlie This fixes a crash in GL43-CTS.shader_subroutine.subroutines_not_allowed_as_variables_constructors_and_argument_or_return_types If we can't find the func_name in one of these paths, we have emitted an earlier error so just return here. Signed-off-by: Dave Airlie --- src/comp