Re: [Mesa-dev] [PATCH] glsl/linker: check same name is not used in block and outside

2018-02-02 Thread Juan A. Suarez Romero
On Wed, 2018-01-31 at 01:38 +0100, Matteo Bruni wrote: > 2018-01-30 16:11 GMT+01:00 Juan A. Suarez Romero : > > According with OpenGL GLSL 3.20 spec, section 4.3.9: > > > > "It is a link-time error if any particular shader interface > >contains: > > - two different

Re: [Mesa-dev] [PATCH] glsl/linker: check same name is not used in block and outside

2018-01-31 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 30.01.2018 17:11, Juan A. Suarez Romero wrote: According with OpenGL GLSL 3.20 spec, section 4.3.9: "It is a link-time error if any particular shader interface contains: - two different blocks, each having no instance name, and

Re: [Mesa-dev] [PATCH] glsl/linker: check same name is not used in block and outside

2018-01-30 Thread Matteo Bruni
2018-01-30 16:11 GMT+01:00 Juan A. Suarez Romero : > According with OpenGL GLSL 3.20 spec, section 4.3.9: > > "It is a link-time error if any particular shader interface >contains: > - two different blocks, each having no instance name, and each >having a

[Mesa-dev] [PATCH] glsl/linker: check same name is not used in block and outside

2018-01-30 Thread Juan A. Suarez Romero
According with OpenGL GLSL 3.20 spec, section 4.3.9: "It is a link-time error if any particular shader interface contains: - two different blocks, each having no instance name, and each having a member of the same name, or - a variable outside a block, and a block with no