Re: [Mesa-dev] [PATCH] glsl/linker: fix bug when checking precision qualifier

2018-02-27 Thread Tapani Pälli
On 27.02.2018 15:07, Samuel Iglesias Gonsálvez wrote: On 27/02/18 13:37, Tapani Pälli wrote: On 01/30/2018 09:50 AM, Samuel Iglesias Gonsálvez wrote: According to GLSL ES 3.2 spec, see table in 9.2.1 "Linked Shaders" section, the precision qualifier should match for uniform variables. Thi

Re: [Mesa-dev] [PATCH] glsl/linker: fix bug when checking precision qualifier

2018-02-27 Thread Samuel Iglesias Gonsálvez
On 27/02/18 13:37, Tapani Pälli wrote: > > > On 01/30/2018 09:50 AM, Samuel Iglesias Gonsálvez wrote: >> According to GLSL ES 3.2 spec, see table in 9.2.1 "Linked Shaders" >> section, the precision qualifier should match for uniform variables. >> This also applies to previous GLSL ES 3.x specs. >

Re: [Mesa-dev] [PATCH] glsl/linker: fix bug when checking precision qualifier

2018-02-27 Thread Tapani Pälli
On 01/30/2018 09:50 AM, Samuel Iglesias Gonsálvez wrote: According to GLSL ES 3.2 spec, see table in 9.2.1 "Linked Shaders" section, the precision qualifier should match for uniform variables. This also applies to previous GLSL ES 3.x specs. This 'if' checks the condition for uniform variables

Re: [Mesa-dev] [PATCH] glsl/linker: fix bug when checking precision qualifier

2018-02-27 Thread Samuel Iglesias Gonsálvez
Still unreviewed. Sam On 12/02/18 09:10, Samuel Iglesias Gonsálvez wrote: > This patch is still unreviewed. > > Sam > > > On 30/01/18 08:50, Samuel Iglesias Gonsálvez wrote: >> According to GLSL ES 3.2 spec, see table in 9.2.1 "Linked Shaders" >> section, the precision qualifier should match for

Re: [Mesa-dev] [PATCH] glsl/linker: fix bug when checking precision qualifier

2018-02-12 Thread Samuel Iglesias Gonsálvez
This patch is still unreviewed. Sam On 30/01/18 08:50, Samuel Iglesias Gonsálvez wrote: > According to GLSL ES 3.2 spec, see table in 9.2.1 "Linked Shaders" > section, the precision qualifier should match for uniform variables. > This also applies to previous GLSL ES 3.x specs. > > This 'if' che

[Mesa-dev] [PATCH] glsl/linker: fix bug when checking precision qualifier

2018-01-29 Thread Samuel Iglesias Gonsálvez
According to GLSL ES 3.2 spec, see table in 9.2.1 "Linked Shaders" section, the precision qualifier should match for uniform variables. This also applies to previous GLSL ES 3.x specs. This 'if' checks the condition for uniform variables, while for UBOs it is checked in link_interface_blocks.cpp.