Re: [Mesa-dev] [PATCH] glsl/mesa: stop duplicating tess layout values

2016-06-22 Thread Timothy Arceri
On Wed, 2016-06-22 at 09:30 +0200, Iago Toral wrote: > On Wed, 2016-06-22 at 09:54 +1000, Timothy Arceri wrote: > > > > On Tue, 2016-06-21 at 17:45 +0200, Iago Toral wrote: > > > > > > On Tue, 2016-06-21 at 12:21 +1000, Timothy Arceri wrote: > > > > > > > > > > > > We already store this in

Re: [Mesa-dev] [PATCH] glsl/mesa: stop duplicating tess layout values

2016-06-22 Thread Iago Toral
On Wed, 2016-06-22 at 09:54 +1000, Timothy Arceri wrote: > On Tue, 2016-06-21 at 17:45 +0200, Iago Toral wrote: > > On Tue, 2016-06-21 at 12:21 +1000, Timothy Arceri wrote: > > > > > > We already store this in gl_shader and gl_program here we > > > remove it from gl_shader_program and just use

Re: [Mesa-dev] [PATCH] glsl/mesa: stop duplicating tess layout values

2016-06-21 Thread Timothy Arceri
On Tue, 2016-06-21 at 17:45 +0200, Iago Toral wrote: > On Tue, 2016-06-21 at 12:21 +1000, Timothy Arceri wrote: > > > > We already store this in gl_shader and gl_program here we > > remove it from gl_shader_program and just use the values > > from gl_shader. > > > > This will allow us to keep

Re: [Mesa-dev] [PATCH] glsl/mesa: stop duplicating tess layout values

2016-06-21 Thread Iago Toral
On Tue, 2016-06-21 at 12:21 +1000, Timothy Arceri wrote: > We already store this in gl_shader and gl_program here we > remove it from gl_shader_program and just use the values > from gl_shader. > > This will allow us to keep the shader cache restore code as > simple as it can be while making it

Re: [Mesa-dev] [PATCH] glsl/mesa: stop duplicating tess layout values

2016-06-21 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Jun 21, 2016 at 4:21 AM, Timothy Arceri wrote: > We already store this in gl_shader and gl_program here we > remove it from gl_shader_program and just use the values > from gl_shader. > > This will allow

[Mesa-dev] [PATCH] glsl/mesa: stop duplicating tess layout values

2016-06-20 Thread Timothy Arceri
We already store this in gl_shader and gl_program here we remove it from gl_shader_program and just use the values from gl_shader. This will allow us to keep the shader cache restore code as simple as it can be while making it somewhat clearer where these values originate from. ---