Re: [Mesa-dev] [PATCH] glsl/shader_cache: restore evicted shader keys

2017-03-26 Thread Timothy Arceri
On 27/03/17 08:44, Timothy Arceri wrote: I'm actually wondering if we still even need the index at all? After bfa95997c4ecf74a329a047359d5e8d1217da49b and b607aad8e1a40c473176e31e11deaa26477c54c0 we should be able to just always set CompileStatus to skipped and fallback to a recompile should the

Re: [Mesa-dev] [PATCH] glsl/shader_cache: restore evicted shader keys

2017-03-26 Thread Timothy Arceri
I'm actually wondering if we still even need the index at all? After bfa95997c4ecf74a329a047359d5e8d1217da49b and b607aad8e1a40c473176e31e11deaa26477c54c0 we should be able to just always set CompileStatus to skipped and fallback to a recompile should the linked program not be found in the

[Mesa-dev] [PATCH] glsl/shader_cache: restore evicted shader keys

2017-03-26 Thread Grazvydas Ignotas
Even though the programs themselves stay in cache and are loaded, the shader keys can be evicted separately. If that happens, unnecessary compiles are caused that waste time, and no matter how many times the program is re-run, performance never recovers to the levels of first hot cache run. To