Ian Romanick writes:
> [ Unknown signature status ]
> On 07/18/2018 03:03 PM, Eric Anholt wrote:
>> Ian Romanick writes:
>>
>>> On 07/16/2018 02:46 PM, Eric Anholt wrote:
This fixes dEQP case:
dEQP-GLES2.functional.shaders.scoping.valid.local_variable_hides_function_parameter_fra
On 07/18/2018 03:03 PM, Eric Anholt wrote:
> Ian Romanick writes:
>
>> On 07/16/2018 02:46 PM, Eric Anholt wrote:
>>> This fixes dEQP case:
>>>
>>> dEQP-GLES2.functional.shaders.scoping.valid.local_variable_hides_function_parameter_fragment
>>
>> Are we sure that test is correct? I'm sure I alre
Ian Romanick writes:
> On 07/16/2018 02:46 PM, Eric Anholt wrote:
>> This fixes dEQP case:
>>
>> dEQP-GLES2.functional.shaders.scoping.valid.local_variable_hides_function_parameter_fragment
>
> Are we sure that test is correct? I'm sure I already know the answer,
> but does the test contain any
On 07/16/2018 02:46 PM, Eric Anholt wrote:
> This fixes dEQP case:
>
> dEQP-GLES2.functional.shaders.scoping.valid.local_variable_hides_function_parameter_fragment
Are we sure that test is correct? I'm sure I already know the answer,
but does the test contain any justification or spec references
On Tue, Jul 17, 2018 at 1:33 PM, Eric Anholt wrote:
> Ilia Mirkin writes:
>
>> On Mon, Jul 16, 2018 at 7:51 PM, Eric Anholt wrote:
>>> Ilia Mirkin writes:
>>>
Perhaps use state->es_shader instead of is_version(0, 100)? [Just a
drive-by comment, not a real review, sorry]
>>>
>>> That d
Ilia Mirkin writes:
> On Mon, Jul 16, 2018 at 7:51 PM, Eric Anholt wrote:
>> Ilia Mirkin writes:
>>
>>> Perhaps use state->es_shader instead of is_version(0, 100)? [Just a
>>> drive-by comment, not a real review, sorry]
>>
>> That doesn't respect the version overrides and such that is_version
>
On Mon, Jul 16, 2018 at 7:51 PM, Eric Anholt wrote:
> Ilia Mirkin writes:
>
>> Perhaps use state->es_shader instead of is_version(0, 100)? [Just a
>> drive-by comment, not a real review, sorry]
>
> That doesn't respect the version overrides and such that is_version
> handles.
Under what circumst
Ilia Mirkin writes:
> Perhaps use state->es_shader instead of is_version(0, 100)? [Just a
> drive-by comment, not a real review, sorry]
That doesn't respect the version overrides and such that is_version
handles.
signature.asc
Description: PGP signature
Perhaps use state->es_shader instead of is_version(0, 100)? [Just a
drive-by comment, not a real review, sorry]
On Mon, Jul 16, 2018 at 5:46 PM, Eric Anholt wrote:
> This fixes dEQP case:
>
> dEQP-GLES2.functional.shaders.scoping.valid.local_variable_hides_function_parameter_fragment
>
> without
This fixes dEQP case:
dEQP-GLES2.functional.shaders.scoping.valid.local_variable_hides_function_parameter_fragment
without breaking
dEQP-GLES3.functional.shaders.scoping.invalid.local_variable_hides_function_parameter_fragment
---
src/compiler/glsl/ast_to_hir.cpp | 9 +
1 file changed,
10 matches
Mail list logo