[Mesa-dev] [PATCH] glsl: Disallow uniform block layout qualifiers on non-uniform block vars.

2013-08-26 Thread Matt Turner
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=68460 Cc: 9.2 mesa-sta...@lists.freedesktop.org --- src/glsl/ast_to_hir.cpp | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index feff586..bb25d81 100644

Re: [Mesa-dev] [PATCH] glsl: Disallow uniform block layout qualifiers on non-uniform block vars.

2013-08-26 Thread Ian Romanick
On 08/26/2013 02:16 PM, Matt Turner wrote: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=68460 Cc: 9.2 mesa-sta...@lists.freedesktop.org --- src/glsl/ast_to_hir.cpp | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp

Re: [Mesa-dev] [PATCH] glsl: Disallow uniform block layout qualifiers on non-uniform block vars.

2013-08-26 Thread Matt Turner
On Mon, Aug 26, 2013 at 4:35 PM, Ian Romanick i...@freedesktop.org wrote: I think this will allow things like: struct foo { layout(row_major) mat4 bar; }; Yeah? Don't think so: error: syntax error, unexpected LAYOUT_TOK ___ mesa-dev mailing

Re: [Mesa-dev] [PATCH] glsl: Disallow uniform block layout qualifiers on non-uniform block vars.

2013-08-26 Thread Ian Romanick
On 08/26/2013 04:49 PM, Matt Turner wrote: On Mon, Aug 26, 2013 at 4:35 PM, Ian Romanick i...@freedesktop.org wrote: I think this will allow things like: struct foo { layout(row_major) mat4 bar; }; Yeah? Don't think so: error: syntax error, unexpected LAYOUT_TOK Right... because