Re: [Mesa-dev] [PATCH] glsl: Enable split of lower UBOs and SSBO also for compute shaders

2015-10-14 Thread Iago Toral
On Wed, 2015-10-14 at 16:18 +0300, Francisco Jerez wrote: > "Lofstedt, Marta" writes: > > > I have found a couple of more places in linker.cpp where we loop up to > > MESA_SHADER_FRAGMENT. > > Should these now also be up to MESA_SHADER_COMPUTE instead? > > > Some might be oversights like this, b

Re: [Mesa-dev] [PATCH] glsl: Enable split of lower UBOs and SSBO also for compute shaders

2015-10-14 Thread Lofstedt, Marta
> -Original Message- > From: Francisco Jerez [mailto:curroje...@riseup.net] > Sent: Wednesday, October 14, 2015 3:18 PM > To: Lofstedt, Marta; Marta Lofstedt; mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH] glsl: Enable split of lower UBOs and SSBO >

Re: [Mesa-dev] [PATCH] glsl: Enable split of lower UBOs and SSBO also for compute shaders

2015-10-14 Thread Francisco Jerez
"Lofstedt, Marta" writes: > I have found a couple of more places in linker.cpp where we loop up to > MESA_SHADER_FRAGMENT. > Should these now also be up to MESA_SHADER_COMPUTE instead? > Some might be oversights like this, but I guess in some cases a loop up to MESA_SHADER_FRAGMENT might be the

Re: [Mesa-dev] [PATCH] glsl: Enable split of lower UBOs and SSBO also for compute shaders

2015-10-14 Thread Lofstedt, Marta
I have found a couple of more places in linker.cpp where we loop up to MESA_SHADER_FRAGMENT. Should these now also be up to MESA_SHADER_COMPUTE instead? /Marta > -Original Message- > From: Marta Lofstedt [mailto:marta.lofst...@linux.intel.com] > Sent: Wednesday, October 14, 2015 2:56 PM

Re: [Mesa-dev] [PATCH] glsl: Enable split of lower UBOs and SSBO also for compute shaders

2015-10-14 Thread Francisco Jerez
Hi Marta, Marta Lofstedt writes: > From: Marta Lofstedt > > The split of Uniform blocks and shader storage block only loops > up to MESA_SHADER_FRAGMENT and igonres compute shaders. > This cause segfault when running the OpenGL ES 3.1 CTS tests > with GL_ARB_compute_shader enabled. > > Signed-o

[Mesa-dev] [PATCH] glsl: Enable split of lower UBOs and SSBO also for compute shaders

2015-10-14 Thread Marta Lofstedt
From: Marta Lofstedt The split of Uniform blocks and shader storage block only loops up to MESA_SHADER_FRAGMENT and igonres compute shaders. This cause segfault when running the OpenGL ES 3.1 CTS tests with GL_ARB_compute_shader enabled. Signed-off-by: Marta Lofstedt --- src/glsl/linker.cpp |