subject:"\[Mesa\-dev\] \[PATCH\] glsl\: Fix gl_shader_program\:\:UniformLocationBaseScale assert."

Re: [Mesa-dev] [PATCH] glsl: Fix gl_shader_program::UniformLocationBaseScale assert.

2013-06-25 Thread Ian Romanick

On 06/24/2013 11:02 PM, Vinson Lee wrote: commit 26d86d26f9f972b19c7040bdb1b1daf48537ef3e added gl_shader_program::UniformLocationBaseScale. According to the code comments in that commit, UniformLocationBaseScale "must be >=1". UniformLocationBaseScale is of type unsigned. Coverity reported a "M

[Mesa-dev] [PATCH] glsl: Fix gl_shader_program::UniformLocationBaseScale assert.

2013-06-24 Thread Vinson Lee

commit 26d86d26f9f972b19c7040bdb1b1daf48537ef3e added gl_shader_program::UniformLocationBaseScale. According to the code comments in that commit, UniformLocationBaseScale "must be >=1". UniformLocationBaseScale is of type unsigned. Coverity reported a "Macro compares unsigned to 0" defect as well.