[Mesa-dev] [PATCH] glsl: Fix clang mismatched-tags warnings with glsl_type.

2014-06-15 Thread Vinson Lee
Fix clang mismatched-tags warnings introduced with commit 4f5445a45d3ed02e00a061b10c943c0b079c6020. ./glsl_symbol_table.h:37:1: warning: class 'glsl_type' was previously declared as a struct [-Wmismatched-tags] class glsl_type; ^ ./glsl_types.h:86:8: note: previous use is here struct glsl_type {

Re: [Mesa-dev] [PATCH] glsl: Fix clang mismatched-tags warnings with glsl_type.

2014-06-15 Thread Matt Turner
I just wrote the same patch tonight. :) Reviewed-by: Matt Turner matts...@gmail.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] glsl: Fix clang mismatched-tags warnings with glsl_type.

2014-06-15 Thread Thomas Helland
Ooops. My bad. Thanks for fixing this. LGTM Reading up on this warning it seems name mangling is pretty messed up with MSVC. I'll get a MSVC build system set up to make sure my future work extraneous includes does not introduce issues with MSVC. 2014-06-15 9:38 GMT+02:00 Matt Turner

Re: [Mesa-dev] [PATCH] glsl: Fix clang mismatched-tags warnings with glsl_type.

2014-06-15 Thread Matt Turner
On Sun, Jun 15, 2014 at 3:58 AM, Thomas Helland thomashellan...@gmail.com wrote: Ooops. My bad. Thanks for fixing this. LGTM Reading up on this warning it seems name mangling is pretty messed up with MSVC. I'll get a MSVC build system set up to make sure my future work extraneous includes