Re: [Mesa-dev] [PATCH] glsl: OpenGLES GLSL 3.1 precision qualifiers ordering rules

2015-11-02 Thread Iago Toral
On Sat, 2015-10-31 at 23:22 -0700, Jordan Justen wrote: > On 2015-10-29 01:22:37, Iago Toral wrote: > > On Thu, 2015-10-29 at 00:47 -0700, Jordan Justen wrote: > > > The OpenGLES GLSL 3.1 specification uses the precision qualifier > > > ordering rules from ARB_shading_language_420pack. > > > > May

Re: [Mesa-dev] [PATCH] glsl: OpenGLES GLSL 3.1 precision qualifiers ordering rules

2015-10-31 Thread Jordan Justen
On 2015-10-29 01:22:37, Iago Toral wrote: > On Thu, 2015-10-29 at 00:47 -0700, Jordan Justen wrote: > > The OpenGLES GLSL 3.1 specification uses the precision qualifier > > ordering rules from ARB_shading_language_420pack. > > Maybe expand the commit log to make explicit that this is for GLES 3.1

Re: [Mesa-dev] [PATCH] glsl: OpenGLES GLSL 3.1 precision qualifiers ordering rules

2015-10-29 Thread Lofstedt, Marta
Reviewed-by: Marta Lofstedt > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Jordan Justen > Sent: Thursday, October 29, 2015 8:47 AM > To: mesa-dev@lists.freedesktop.org > Subject: [Mesa-dev] [PATCH] glsl: OpenGLES

Re: [Mesa-dev] [PATCH] glsl: OpenGLES GLSL 3.1 precision qualifiers ordering rules

2015-10-29 Thread Iago Toral
On Thu, 2015-10-29 at 00:47 -0700, Jordan Justen wrote: > The OpenGLES GLSL 3.1 specification uses the precision qualifier > ordering rules from ARB_shading_language_420pack. Maybe expand the commit log to make explicit that this is for GLES 3.1 and desktop GL since 4.2 Reviewed-by: Iago Toral Qu

Re: [Mesa-dev] [PATCH] glsl: OpenGLES GLSL 3.1 precision qualifiers ordering rules

2015-10-29 Thread Jordan Justen
On 2015-10-29 00:53:01, Ilia Mirkin wrote: > Would it make sense to just modify the has_420pack function? Or do you > not want all of it? Yeah, that was my first thought. Looking at the OpenGLES 3.1 spec, it seems to not have picked up very much of 420pack. This was the only part I've noticed so

Re: [Mesa-dev] [PATCH] glsl: OpenGLES GLSL 3.1 precision qualifiers ordering rules

2015-10-29 Thread Ilia Mirkin
Would it make sense to just modify the has_420pack function? Or do you not want all of it? On Thu, Oct 29, 2015 at 3:47 AM, Jordan Justen wrote: > The OpenGLES GLSL 3.1 specification uses the precision qualifier > ordering rules from ARB_shading_language_420pack. > > Signed-off-by: Jordan Justen

[Mesa-dev] [PATCH] glsl: OpenGLES GLSL 3.1 precision qualifiers ordering rules

2015-10-29 Thread Jordan Justen
The OpenGLES GLSL 3.1 specification uses the precision qualifier ordering rules from ARB_shading_language_420pack. Signed-off-by: Jordan Justen --- src/glsl/glsl_parser.yy | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy