Re: [Mesa-dev] [PATCH] glsl: Remove VS output varyings which are optimized out of the FS

2013-02-17 Thread Paul Berry
On 17 February 2013 14:32, Ian Romanick wrote: > On 02/12/2013 06:59 PM, Jordan Justen wrote: > >> Previously when an input varying was optimized out of the >> FS we would still retain it as an output of the VS. >> >> We now build a hash of live FS input varyings rather >> than looking in the FS

Re: [Mesa-dev] [PATCH] glsl: Remove VS output varyings which are optimized out of the FS

2013-02-17 Thread Ian Romanick
On 02/12/2013 06:59 PM, Jordan Justen wrote: Previously when an input varying was optimized out of the FS we would still retain it as an output of the VS. We now build a hash of live FS input varyings rather than looking in the FS symbol table. (The FS symbol table will still contain the optimiz

Re: [Mesa-dev] [PATCH] glsl: Remove VS output varyings which are optimized out of the FS

2013-02-17 Thread Kenneth Graunke
On 02/12/2013 06:59 PM, Jordan Justen wrote: Previously when an input varying was optimized out of the FS we would still retain it as an output of the VS. We now build a hash of live FS input varyings rather than looking in the FS symbol table. (The FS symbol table will still contain the optimiz

Re: [Mesa-dev] [PATCH] glsl: Remove VS output varyings which are optimized out of the FS

2013-02-15 Thread Paul Berry
On 12 February 2013 18:59, Jordan Justen wrote: > Previously when an input varying was optimized out of the > FS we would still retain it as an output of the VS. > > We now build a hash of live FS input varyings rather > than looking in the FS symbol table. (The FS symbol table > will still conta

Re: [Mesa-dev] [PATCH] glsl: Remove VS output varyings which are optimized out of the FS

2013-02-12 Thread Jordan Justen
Paul, Ken, In case you were interested, I confirmed that this fixes (or more accurately it masks) the Steam Big Picture issue that Ken fixed in 09fbc298. (I checked the effects of this patch with 09fbc298 removed.) You two had suspected this change might mask that particular issue. -Jordan On T

[Mesa-dev] [PATCH] glsl: Remove VS output varyings which are optimized out of the FS

2013-02-12 Thread Jordan Justen
Previously when an input varying was optimized out of the FS we would still retain it as an output of the VS. We now build a hash of live FS input varyings rather than looking in the FS symbol table. (The FS symbol table will still contain the optimized out varyings.) Signed-off-by: Jordan Justen