Re: [Mesa-dev] [PATCH] glsl: add default switch case to silence uninitialized variable warning

2013-08-23 Thread Chad Versace
On 08/23/2013 02:05 PM, Paul Berry wrote: On 23 August 2013 13:55, Brian Paul wrote: On 08/23/2013 02:39 PM, Matt Turner wrote: On Fri, Aug 23, 2013 at 1:24 PM, Brian Paul wrote: In that case, let's fix it by initializing limit to 0 at its declaration. That way we will get a (helpful) co

Re: [Mesa-dev] [PATCH] glsl: add default switch case to silence uninitialized variable warning

2013-08-23 Thread Paul Berry
On 23 August 2013 13:55, Brian Paul wrote: > On 08/23/2013 02:39 PM, Matt Turner wrote: > >> On Fri, Aug 23, 2013 at 1:24 PM, Brian Paul wrote: >> >>> --- >>> src/glsl/ast_to_hir.cpp |3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to

Re: [Mesa-dev] [PATCH] glsl: add default switch case to silence uninitialized variable warning

2013-08-23 Thread Brian Paul
On 08/23/2013 02:39 PM, Matt Turner wrote: On Fri, Aug 23, 2013 at 1:24 PM, Brian Paul wrote: --- src/glsl/ast_to_hir.cpp |3 +++ 1 file changed, 3 insertions(+) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index feff586..24efec6 100644 --- a/src/glsl/ast_to_hir.cpp ++

Re: [Mesa-dev] [PATCH] glsl: add default switch case to silence uninitialized variable warning

2013-08-23 Thread Matt Turner
On Fri, Aug 23, 2013 at 1:24 PM, Brian Paul wrote: > --- > src/glsl/ast_to_hir.cpp |3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp > index feff586..24efec6 100644 > --- a/src/glsl/ast_to_hir.cpp > +++ b/src/glsl/ast_to_hir.cpp > @@

[Mesa-dev] [PATCH] glsl: add default switch case to silence uninitialized variable warning

2013-08-23 Thread Brian Paul
--- src/glsl/ast_to_hir.cpp |3 +++ 1 file changed, 3 insertions(+) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index feff586..24efec6 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -1933,6 +1933,9 @@ validate_binding_qualifier(struct _mesa_glsl_parse