Re: [Mesa-dev] [PATCH] glsl: be more strict when validating shader inputs

2016-05-12 Thread Chris Forbes
With the version cutoff fixed, this and the patch it builds on are (squashed together or not): Reviewed-by: Chris Forbes On Fri, May 13, 2016 at 4:58 PM, Ilia Mirkin wrote: > On Fri, May 13, 2016 at 12:51 AM, Dave Airlie wrote:

Re: [Mesa-dev] [PATCH] glsl: be more strict when validating shader inputs

2016-05-12 Thread Ilia Mirkin
On Fri, May 13, 2016 at 12:51 AM, Dave Airlie wrote: >>> second argument is for ES... 0 means "never"). >> >> I see. (You can tell how much of this sort of code I've written...). >> >> I don't know that I'd trust me but it looks fine as far add I can see. >> Thanks for taking

Re: [Mesa-dev] [PATCH] glsl: be more strict when validating shader inputs

2016-05-12 Thread Dave Airlie
>> second argument is for ES... 0 means "never"). > > I see. (You can tell how much of this sort of code I've written...). > > I don't know that I'd trust me but it looks fine as far add I can see. > Thanks for taking care of 4.50 while you were in the neighborhood. For what > it's worth, Do we

Re: [Mesa-dev] [PATCH] glsl: be more strict when validating shader inputs

2016-05-12 Thread Jason Ekstrand
On May 12, 2016 9:42 PM, "Ilia Mirkin" wrote: > > On Fri, May 13, 2016 at 12:41 AM, Jason Ekstrand wrote: > > > > On May 12, 2016 9:29 PM, "Ilia Mirkin" wrote: > >> > >> interpolateAt* can only take input variables or an element

Re: [Mesa-dev] [PATCH] glsl: be more strict when validating shader inputs

2016-05-12 Thread Jason Ekstrand
On May 12, 2016 9:41 PM, "Jason Ekstrand" wrote: > > > On May 12, 2016 9:29 PM, "Ilia Mirkin" wrote: > > > > interpolateAt* can only take input variables or an element of an input > > variable array. No structs. > > > > Further, GLSL 4.50 relaxes the

Re: [Mesa-dev] [PATCH] glsl: be more strict when validating shader inputs

2016-05-12 Thread Ilia Mirkin
On Fri, May 13, 2016 at 12:41 AM, Jason Ekstrand wrote: > > On May 12, 2016 9:29 PM, "Ilia Mirkin" wrote: >> >> interpolateAt* can only take input variables or an element of an input >> variable array. No structs. >> >> Further, GLSL 4.50 relaxes the

Re: [Mesa-dev] [PATCH] glsl: be more strict when validating shader inputs

2016-05-12 Thread Jason Ekstrand
On May 12, 2016 9:29 PM, "Ilia Mirkin" wrote: > > interpolateAt* can only take input variables or an element of an input > variable array. No structs. > > Further, GLSL 4.50 relaxes the requirement to allow swizzles, so enable > that as well. > > This fixes the following

[Mesa-dev] [PATCH] glsl: be more strict when validating shader inputs

2016-05-12 Thread Ilia Mirkin
interpolateAt* can only take input variables or an element of an input variable array. No structs. Further, GLSL 4.50 relaxes the requirement to allow swizzles, so enable that as well. This fixes the following dEQP tests: